Support default value on a table where id is a UUID about safe-pg-migrations HOT 9 CLOSED

To close?

from safe-pg-migrations.

To close?

If you don't need this feature anymore, you can definitively close this old PR

from safe-pg-migrations.

I believe this issue is still a real problem; with a UUID as a primary key (or actually with any table whose primary key is not an integer named id), backfilling the default value would not work.

On the other hand, this method is only used with old versions of PG. Fixing the library is tricky here, a better solution would be to simply update the README, indicating that a numeric primary key named id is required for having the backfill work.

from safe-pg-migrations.

Is there a way to disable the backfill in batches logic? Most of our tables have uuid as primary keys which will make usage of this gem impossible :(

from safe-pg-migrations.

Hey @mikatuo, which version of PG are you using? If you are using PG11+ this logic is disabled as it's handled by PG itself.
If not, we should adapt the backfill logic to make it work with uuid primary keys.

from safe-pg-migrations.

9.6

from safe-pg-migrations.

Hi there, just found this issue and it affects me too. I'm using PSQL 10.12 so the new logic didn't kick in either.

from safe-pg-migrations.

A good solution for that would be to rely on BatchEnumerator or directly in_batches, in the method backfill_column_default

I am not planning to work on it soon, but I'd be happy to review a PR :)

from safe-pg-migrations.

Hey @mikatuo, @pablosole and maybe @DrPlop, I merged a PR which should solve the issue, can you tell me if it solves your issue?

I'm about to release a new version of the gem, but if you want to try it sooner you should rely on the last commit

from safe-pg-migrations.