Comments (5)
Not sure exactly what you call "obvious".. check this PR where I'm adding a new sniff and many files of this repo do not comply with it.
Right from the first job you'll notice the PHP 72 that is successful.
from coding-standard.
@gmponos thanks for reporting this issue 👍
from coding-standard.
It does look weird… can you try doing an obvious mistake in one of your PRs and see if it is caught by that job?
from coding-standard.
Link for the lazy: https://github.com/doctrine/coding-standard/pull/206/checks?check_run_id=791333879
I think the issue would have to do with this line:
Line 9 in 87308f5
I think it is equivalent to
vendor/bin/phpcs `find tests/input/* | sort` --report=summary --report-file=phpcs.log
diff -u tests/expected_report.txt phpcs.log
if [ $$? -ne 0 ] && [ $(PHP_74_OR_NEWER) -eq 1 ]
then
git apply -R tests/php-compatibility.patch
exit 1
fi
This does not make much sense… maybe it should really be
vendor/bin/phpcs `find tests/input/* | sort` --report=summary --report-file=phpcs.log
diff -u tests/expected_report.txt phpcs.log
if [ $(PHP_74_OR_NEWER) -eq 1 ]
then
git apply -R tests/php-compatibility.patch
fi
if [ $$? -ne 0 ]
then
exit 1
fi
It was introduced as such in f9d89e0 as part of #144
@lcobucci can you please advise?
from coding-standard.
@greg0ire oh my, that's indeed a terrible mistake.
It seems to be failing since #148.
I believe it should have been something like this:
if [ $$? -ne 0 ]; then
if [ $(PHP_74_OR_NEWER) -eq 1 ]; then
git apply -R tests/php-compatibility.patch;
fi
exit 1;
fi
Fixed in #210
from coding-standard.
Related Issues (20)
- Use stable release of slevomat/coding-standard HOT 4
- PSR-12 integration HOT 2
- A phpDoc template closing tag is mistakenly considered belonging to the following function
- False positive using intersection types in type annotation HOT 4
- Add SlevomatCodingStandard.Functions.StrictCall HOT 3
- Forbid more functions
- doctrine/coding-standard 8.0.0 requires dealerdirect/phpcodesniffer-composer-installer ^0.6.2 HOT 1
- phpcs: ERROR: Referenced sniff "SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace" does not exist HOT 1
- duplicate rules for visibility of class constants
- class and properties with no spaces between them seem to be allowed
- Ignore some case for EarlyExit rule HOT 1
- Consider dropping auto fix of `SlevomatCodingStandard.Classes.ClassConstantVisibility` HOT 5
- suggestion: a good readme HOT 2
- Support for PHPCS ^4.0 HOT 2
- Reconsider enforcement of union types over the nullable ones HOT 6
- Add WordpressArray sniff HOT 4
- New version HOT 5
- Duplicate `RequireOneLineDocComment` in ruleset HOT 1
- Switch to phpcsstandards/codesniffer HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coding-standard.