doctrine:generate:entities regenerates privates for abstract or traits about doctrinebundle HOT 12 CLOSED

@jsgoupil when you opened it on symfony yesterday, I asked you to report it to the doctrine ORM, not to the doctrine bundle. The EntityGenerator is not part of DoctrineBundle either

from doctrinebundle.

@stof Well well sorry not being that proficient in Symfony, I looked up where the call was then looked up on packagist.org ...

I think you guys can take care of it and transfer it now...

from doctrinebundle.

Please fix this. Such basic bugs.. doesn't look like you guys ever eat your own dog food.

from doctrinebundle.

huh? how about you fix it then!

from doctrinebundle.

@salmanpk Most Doctrine devs are indeed not using the code generation. the EntityGenerator has never been considered as a first-class citizen in Doctrine2 but only as an helper.

Thus, this issue should be reported to the Doctrine ORM project (which is where the generator is defined) instead of in the bundle (where we cannot do anything about it as we simply call the generator)

from doctrinebundle.

@jsgoupil and @salmanpk I think you're having an issue on understanding how open source software works, not an issue with the DoctrineBundle itself. Try to reconsider your points. That's IMHO, no offense.

from doctrinebundle.

Man you guys are way more patient than I would be. I'd have closed this issue as "invalid" or "not a bug" with a link to where he actually needs to report it and moved on by now lol

from doctrinebundle.

its important to try and stay solution oriented .. in that way @stof's reply was much better than mine. if we as a community act civil, it will be the best way to encourage others to act the same way.

from doctrinebundle.

Hi @jsgoupil ,

Thank you for taking the time to report this. @stof wanted the bug report opened here: http://www.doctrine-project.org/jira/browse/DDC so it could be tracked better. I know you already re-opened this once. If you need help, just ping me and I can open it on your behalf.

from doctrinebundle.

I opened a ticket on DDC here: http://www.doctrine-project.org/jira/browse/DDC-2154

In general all the core contributors use Doctrine in their work projects. That doesn't mean that we use some use case or feature, for example the EntityGenerator in combination with Traits. It is very special.

As we have day jobs, you can always help by opening Pull Requests. But I know that you having day jobs as well, fixing something on an open source project isn't always possible.

from doctrinebundle.

Thanks a lot everyone. To be clear: I was not using any abstract classes or traits, just plain old inheritance.

Sorry if I came off as mean, was a bit frustrated because of a deadline. I wont be sticking with PHP If it wasn't for the great work you guys have done which I really appreciate and inspires me. idk why I have to hit a few bugs every single project.. just bad luck :)

@giorrrgio You're right. Lazy me. I thought I'd have to understand how the EntityGenerator class works and create a test case for reporting a doctrine bug (here we can just say that the command is broken heh) and I was short on time at the moment. I don't know how this accounts for my understanding of open source software as a whole though.

from doctrinebundle.

@salmanpk I think your own last post makes the point even clearer: your comment ("Such basic bugs.. doesn't look like you guys ever eat your own dog food") was not useful for solving the problem, and a bit offending for those who gives their free time to OSS development. Opening an issue without writing tests is always okay, making a pull request with tests is always great, unhelping complains like that are always bad. I know that working with deadlines and broken vendor dependencies or broken vendor commits is very frustrating, it happens often here too. But please try to stick to your last post's constructive intent next time ;-)

from doctrinebundle.