Giter VIP home page Giter VIP logo

Comments (6)

stof avatar stof commented on June 10, 2024

This will be difficult as the 2.0 branch is currently the sf 2.0 compatibility branch, and renaming it to 1.x will break all projects relying on deps files (i.e. most project using it). and if you don't rename it to avoid breaking the existing projects, composer will consider it as 2.0.x-dev

from doctrinemongodbbundle.

jmikola avatar jmikola commented on June 10, 2024

Then I suppose we're forced to start the bundle version at 2.0, use 2.1 for the mapping refactoring, and 3.0 for Symfony 2.1 compatibility.

from doctrinemongodbbundle.

jmikola avatar jmikola commented on June 10, 2024

I created tags for doctrine/mongodb and ODM as described above.

@stof: Per semver.org, any BC breaks in the public API necessitate a major version bump. My plan for sf2.0-pre-common-mapping was to checkout fd7ac2f (before I merged your PR), add a commit to update composer.json and then tag that as 2.0.0. The commit wouldn't appear in the 2.0 branch history, but it'd stick around in Git so long as the tag referenced it.

Then, I would need a 3.0.0 tag for the 2.0 branch head, and a 4.0.0 tag for master's head. The problem there is that the 2.0 branch now has content beyond the 2.0.0 tag (i.e. stuff from 3.0.0). This seems like a maintenance headache.

So, new proposal: tag the commit before your PR as 2.0.0-BETA1 and the current 2.0 branch head as 2.0.0-BETA2. The master head can be tagged as 3.0.0-BETA1. Thoughts?

from doctrinemongodbbundle.

jmikola avatar jmikola commented on June 10, 2024

It looks like old v2.0.0 and v2.0.1 tags already exist here, so we'll have to respect those.

from doctrinemongodbbundle.

jmikola avatar jmikola commented on June 10, 2024

There don't appear to be any BC breaks between the v2.0.1 and the point before common mapping was merged (see diff). I'm going to make a commit after fd7ac2f and tag that as v2.1.0.

The diff of the 2.0 branch since mapping refactoring was introduced isn't too large, and it's debatable if the mapping changes are public API changes. I'll tag that as v2.2.0.

The master branch has changed significantly, so I'm going to start that at v3.0.0-BETA1. Once Symfony 2.1 is released, we can move to a v3.0.0 release.

Documentation updates will follow.

from doctrinemongodbbundle.

jmikola avatar jmikola commented on June 10, 2024

Tags:

Documentation changes:

That's a wrap.

from doctrinemongodbbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.