Comments (6)
lsmith77
commented on August 23, 2024
can you turn this into a failing test case?
from phpcr-odm.
sarcher
commented on August 23, 2024
First commit contains the functional tests; second commit contains the fix. I broke them up so you could more easily observe the failures against the current code.
Note the use of strcmp in the fixed code, since array keys can be either integers or strings we need a type-safe comparison between the two.
Comments welcome -- I think I understand things but I am pretty new to the code. This did fix the issue I was having, and all of the existing tests pass so I hope there is no regression introduced.
from phpcr-odm.
lsmith77
commented on August 23, 2024
can you open a PR with your changes? makes reviewing easier
from phpcr-odm.
sarcher
commented on August 23, 2024
Done, although it seems to have created a new issue, so clearly I am not doing it correctly. : )
from phpcr-odm.
lsmith77
commented on August 23, 2024
that is the normal behavior .. so all is well :)
from phpcr-odm.
dbu
commented on August 23, 2024
fixed in #390 right? please reopen if i am mistaken and there is something left.
from phpcr-odm.
Related Issues (20)
- Proxy awake on requesting node name
- Binding string with apostrophe using QueryBuilder->literal() crash query HOT 3
- PHP 7 compability issue HOT 4
- How to query @PHPCR\ReferenceMany on Document of same class HOT 2
- Master broken in rebuild HOT 8
- Having problem with 2 ODM managers HOT 1
- GenericDocument.php HOT 1
- Cannot remove nodes with autogenerated @Nodename HOT 1
- translator="attribute" in MetaData is NULL HOT 3
- QueryBuilder: Is it possible to order by id? HOT 3
- Results are not sorted with query builder HOT 4
- QueryBuilder throws InvalidQueryException if node path contains '-<num>e' HOT 1
- Children class Docs vs. Schema defintion HOT 1
- Inheritance for lifecycle callbacks HOT 11
- Array Equality Checking for reordering in UnitOfWork HOT 5
- Classes with names int, string, float, bool... are forbidden in PHP7 HOT 3
- [BUG?] QueryBuilder::setParameter does not exist, so it's not possible to add them during query building HOT 1
- about create indexes HOT 3
- ObjectManager::find requires class name HOT 1
- Symfony 7 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpcr-odm.