find() with wrong class name about phpcr-odm HOT 9 CLOSED

yes .. this is a "feature" .. allowing you to cast to other types. however it gets really messy as anyone calling find afterwards will get the casted version. so its a potentially very dangerous feature that we might need to get rid of or limit to subclasses.

from phpcr-odm.

limiting to cast to subclasses sounds ok (we currently already do the oposite, if the stored class is a subclass of the one passed in, the result is of the subclass).

we might add some hint or something to allow the unchecked cast, but then again it seems quite an esoteric use case to me. maybe people should then just ask for the raw phpcr node and map themselves.

from phpcr-odm.

@lsmith77 do we want to change this for 1.1? what approach should we chose? limit to subclasses? which direction makes sense?

1. same class => trivial
2. stored class is a parent of the $class parameter => use $class?
3. stored class is a subclass of the $class parameter => use the subclass? or the $class?
4. everything else would throw an exceptoin

from phpcr-odm.

I am +1 for returning the original class or a class with the original class in its "classparents" attribute. I am almost 100% sure that this is what the ORM does.

e.g.

$content = $dm->find('Cms\Content', '/cms/content/article-content'); //returns Cms\ArticleContent for example

https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L2949

from phpcr-odm.

with original class you mean the one passed as $class argument, right?

so for 2. what would happen? in your example, it would be find('Cms\ArticleContent', '/cms/content') and there is a Cms\Content at that path.

from phpcr-odm.

I would expect it to return null I think

from phpcr-odm.

so if the class stored and the class requested do not match, you expect null to be returned?

from phpcr-odm.

the null feels weird to me too. the only comparable situation in orm would be table inheritance.

say i have class Abstract and class A extends Abstract and class B extends Abstract. when i do $em->find('A', 42) but 42 is of class B, what does the orm do? (i guess i should do find('Abstract', 42) usually, but say i expect to really find A. will the orm return me B(42) or null or throw an exception? @beberlei or @Ocramius would you happen to know this?

from phpcr-odm.

trying to get some input on this with a tweet. would love to clean it up for 1.1 as its a potential BC break. but one we really need to do as the current state is weird.

from phpcr-odm.