Does not recognise git on windows about doculog HOT 16 CLOSED

Install git from https://git-scm.com/

from doculog.

I don't know how to code in python, so i will send a pseudocode in here:

You could locate the path of the git.exe file https://intellipaat.com/community/23035/where-is-git-exe-located

and then do something like this:
exec_command("C:\Program Files (x86)\Git\Git.exe commit)

from doculog.

Open a Command Prompt. Run setx GCM_TRACE %UserProfile%\git. log ; this will cause the GCM to log to a file located at “%UserProfile%\git. log”.

from doculog.

@Rahuletto we have no control over how users have installed git. This problem exists with users who have working git, but subprocess cannot access it properly (I don't know the root cause of this)

from doculog.

Problem is, it is sometimes not git.exe, but git.cmd

from doculog.

You can probably find what it is thru the system path

from doculog.

I think that in windows, it is never installed as git.exe, it is installed as git.cmd.

I don't know how to code in python, so i will send a pseudocode in here:

You could locate the path of the git.exe file https://intellipaat.com/community/23035/where-is-git-exe-located

and then do something like this: exec_command("C:\Program Files (x86)\Git\Git.exe commit)

from doculog.

C:\Program Files (x86)\Git\

After a bit of research, it seems it may be installed in C:\Program Files\Git too.
I also found that git may be in C:\Program Files\Git\cmd\git.exe

from doculog.

Here is a way I came up with:

from subprocess import check_output 
from sys import stdout
from os.path import splitext


valid_ext = ['.exe', '.cmd', '.bat']
def filter_func(val: str) -> bool:
    if splitext(val)[1] in valid_ext:
        return True


where_output: list[str] = check_output(['where', 'git'])\
                                               .decode(stdout.encoding)\
                                               .split('\n')
# decode to decode bytes
# split just in case there are multiple files
# then filter to remove in case there's something which shouldn't be run

git_location = list(filter(filter_func, where_output))[0].strip()


print(git_location)

So maybe try using something this?

from doculog.

Locate the path of the git.exe to this file https://intellipaat.com/community/23035/where-is-git-exe-located

from doculog.

Instead of subprocess.check_output["git", "log"]) use subprocess.check_output["git", "log"], stdin=date_proc.stdout, stdout=subprocess.PIPE)

from doculog.

please create a pull request fixing the issue mentioned above

from doculog.

@L0RD-ZER0 can I have your discord tag?

from doculog.

@L0RD-ZER0 can I have your discord tag?

You can useThe One#9690 to get in touch.

from doculog.

Wasn't this fixed in fa6018b

from doculog.

@pgamerx That's correct. Thanks, closing now.

Fixed by #29

from doculog.