Comments (9)
Confirmed with iwyu:
bench/bench.h should add these lines:
#include <stdint.h> // for uint64_t
#include <boost/function/function_template.hpp> // for function
#include <limits> // for numeric_limits
bench/bench.h should remove these lines:
- #include <boost/function.hpp> // lines 11-11
I'll make us a cleanup patch on this.
from dogecoin.
boost 1.84.0.
from dogecoin.
Just tested that PR and I was able build and and pass test suite.
Thank you š š
I see some compile time warnings but I'll open for that separated ticket.
from dogecoin.
I ran into this same issue on archlinux with their patched boost-1.83.0-5 on 1.15.0-dev and all prior versions including 1.14.6:
build log
332.3 CXX bench/bench_dogecoin-bench_bitcoin.o
333.8 In file included from bench/bench_bitcoin.cpp:5:
333.8 bench/bench.h: In constructor ābenchmark::State::State(std::string, double)ā:
333.8 bench/bench.h:52:28: error: ānumeric_limitsā is not a member of āstdā
333.8 52 | minTime = std::numeric_limits<double>::max();
333.8 | ^~~~~~~~~~~~~~
333.8 bench/bench.h:52:43: error: expected primary-expression before ādoubleā
333.8 52 | minTime = std::numeric_limits<double>::max();
333.8 | ^~~~~~
333.8 bench/bench.h:53:28: error: ānumeric_limitsā is not a member of āstdā
333.8 53 | maxTime = std::numeric_limits<double>::min();
333.8 | ^~~~~~~~~~~~~~
333.8 bench/bench.h:53:43: error: expected primary-expression before ādoubleā
333.8 53 | maxTime = std::numeric_limits<double>::min();
333.8 | ^~~~~~
333.8 bench/bench.h:54:30: error: ānumeric_limitsā is not a member of āstdā
333.8 54 | minCycles = std::numeric_limits<uint64_t>::max();
333.8 | ^~~~~~~~~~~~~~
333.8 bench/bench.h:54:53: error: expected primary-expression before ā>ā token
333.8 54 | minCycles = std::numeric_limits<uint64_t>::max();
333.8 | ^
333.8 bench/bench.h:54:56: error: ā::maxā has not been declared; did you mean āstd::maxā?
333.8 54 | minCycles = std::numeric_limits<uint64_t>::max();
333.8 | ^~~
333.8 | std::max
333.8 In file included from /usr/include/c++/13.2.1/algorithm:61,
333.8 from /usr/include/boost/function/detail/prologue.hpp:14,
333.8 from /usr/include/boost/function.hpp:30,
333.8 from bench/bench.h:11:
333.8 /usr/include/c++/13.2.1/bits/stl_algo.h:5805:5: note: āstd::maxā declared here
333.8 5805 | max(initializer_list<_Tp> __l, _Compare __comp)
333.8 | ^~~
333.8 bench/bench.h:55:30: error: ānumeric_limitsā is not a member of āstdā
333.8 55 | maxCycles = std::numeric_limits<uint64_t>::min();
333.8 | ^~~~~~~~~~~~~~
333.8 bench/bench.h:55:53: error: expected primary-expression before ā>ā token
333.8 55 | maxCycles = std::numeric_limits<uint64_t>::min();
333.8 | ^
333.8 bench/bench.h:55:56: error: ā::minā has not been declared; did you mean āstd::minā?
333.8 55 | maxCycles = std::numeric_limits<uint64_t>::min();
333.8 | ^~~
333.8 | std::min
333.8 /usr/include/c++/13.2.1/bits/stl_algo.h:5785:5: note: āstd::minā declared here
333.8 5785 | min(initializer_list<_Tp> __l, _Compare __comp)
333.8 | ^~~
336.0 make[2]: Leaving directory '/build/src'
336.0 make[2]: *** [Makefile:8467: bench/bench_dogecoin-bench_bitcoin.o] Error 1
To reproduce, Dockerfile
from #3471 can be used (right now):
FROM archlinux
WORKDIR /build
RUN pacman -Sy \
&& pacman --noconfirm -S git base-devel boost libevent python db
ARG GITREF=1.15.0-dev
ARG MAKEOPTS=-j8
RUN git clone https://github.com/dogecoin/dogecoin.git \
&& cd dogecoin \
&& git checkout $GITREF \
&& ./autogen.sh \
&& ./configure --without-gui --without-miniupnpc \
&& make $MAKEOPTS \
&& make check
This makes the issue broader than just boost 1.84.0 (and therefore more urgent)
from dogecoin.
Thank you. This is probably due to a missing <limits.h>
include.
Which version of boost are you using?
from dogecoin.
If you will have any patch to test please let me know.
from dogecoin.
If I run a docker container w/ fedora:rawhide, I get gcc 14 and boost 1.83. What do I do to get gcc 15 and boost 1.84?
from dogecoin.
I'm using my own distribution which is relatively close to fedora rawhide.
from dogecoin.
Based on the error above, #3456 should fix this.
I need to do a manual boost 1.84 build to verify it fully; please let me know if this fixes the above error in your setup.
from dogecoin.
Related Issues (20)
- Discussion of Redundant Discussions HOT 1
- libdogecoinconsensus shared library HOT 4
- Missing include for std::set in sync.cpp HOT 3
- [feat] Allow rescan on pruned nodes HOT 5
- High Transaction Fee HOT 9
- [bug] asyncore deprecation
- Why does the mining pool change its address every time it mines a block? Does anyone know where this code is? HOT 8
- [bug] new HOT 2
- New HOT 1
- New HOT 1
- How to start a docker based dogecoin full node mainnet HOT 3
- Subject: Inquiry Regarding 2FA Email Not Being Sent on dogechain.info Hello, I hope this message finds you well. I'm encountering an issue with the two-factor authentication (2FA) process on dogechain.info. Despite enabling 2FA on my account, I'm not receiving the authentication emails to my registered email address. Could you please assist me in understanding why the 2FA emails are not being sent? I've verified that my email address is correctly entered in my account settings. Thank you for your attention to this matter.
- doge coin address : DP62MECkViHBdg4U1hzrNPbeESno8CSEDH
- Dogecoin core error, fail to read from database, closing. HOT 3
- Dogecoin needs to solve the problem of being easily attacked by large-scale dust! HOT 2
- Kabosu-chan, the original Shiba Inu is dead
- [bug] Build fails with Protobuf 24.x HOT 1
- [bug] boost 1.85.0 compilation errors
- [feat] Add configuration selected into logs of `dogecoind` HOT 1
- [feat] Change every names and variables containing bitcoin into `src` for dogecoin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dogecoin.