Giter VIP home page Giter VIP logo

Comments (2)

stepanstipl avatar stepanstipl commented on August 29, 2024

Some details on how this should work:

  • Only detect version if one of the relevant collectors (cluster, Helm v2/3) is enabled (I'm thinking about extending the collector interface here)
  • Allow version override via flag - for cases when this is used with files in CI
  • By default filter findings to the relevant ones only, i.e. if it's possible to upgrade (and we have that info)
    • Q1: Should we filter based on the current cluster version or the next minor - assuming the typical scenario is to use this tool when upgrading clusters. I.e:
      a) result.Since <= masterMinorVersion
      b) result.Since <= masterMinorVersion + 1
      In b) case you won't be able to fix this until after the upgrade, so seems like a) might make more sense? Downside potentially missing some issues, although this should never happen in practice, as replacement versions are first introduced and old ones removed only after.
    • Q2: What to do about resources being removed, without replacement? I don't think we have this well covered. I'm thinking just warn about those - Since will be probably when the resource was marked as deprecated in this case, so we might warn a bit early, but better than late ;).
  • Add flag to disable any filtering and display all

@david-doit-intl any thoughts?

from kube-no-trouble.

 avatar commented on August 29, 2024
  1. We should check on the next minor yes 👍 , should have a flag to check up to latest perhaps.
  2. We should defo warn about things being removed!

from kube-no-trouble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.