Cyclic dependency errors with @arcgis/core package about cli-build-app HOT 13 CLOSED

@odoe, @matt-gadd and I tracked down the issue to the html-webpack-plugin and have landed a PR that uses the latest version compatible with webpack 4 (that doesn't use toposort) - I think this is something that we could back port to v7, is that something that you would be interested in?

from cli-build-app.

@odoe I can reproduce, it's a problem we caused on the backport! Luckily we never made it latest so most consumers will still be on 7.0.6 - phew - thanks for letting us know

from cli-build-app.

I think I traced the issue down. I was able to get a better error message by changing the webpack dev.config based on this response to the same issue I was having.
marcelklehr/toposort#20 (comment)

The error seems to stem from using try/catch without defining an error.

// fails to build
try {
	something();
} catch {}

// this works
try {
	something();
} catch (err) {}

Does the dojo build not support es2019 esm?

from cli-build-app.

@agubler a backport would be very helpful for us, thanks!

from cli-build-app.

@odoe Ran into another error during the build (different area) after resolving this one, will continue to look into it - once resolved as long as possible we'll look to back port

from cli-build-app.

@odoe I think we resolved the other build issues and have backported the changes on version 7.0.5, could you give it a try for us?

from cli-build-app.

That works great @agubler! Thanks a lot, now we can better demo use of our API with dojo, much appreciated!

from cli-build-app.

I think I spoke too soon. In a fresh project with 7.0.5, I get this error in a build, even without our arcgis package.

./node_modules/@dojo/webpack-contrib/bootstrap-plugin/async.js
Module build failed (from ./node_modules/@dojo/webpack-contrib/static-build-loader/index.js):

from cli-build-app.

That seems strange. We’ll try and have a look tomorrow.

from cli-build-app.

@odoe did you create a fresh project then manually install 7.0.5 independently? I reproduced the error earlier when doing that, but then I remove node_modules and package-lock.json and the error no longer happens. Could you give that a try for me?

from cli-build-app.

Lol, ok, that works. Thanks!

from cli-build-app.

@odoe Excellent, it looks like it is something to do with how the dependencies are installed which is annoying.

from cli-build-app.

7.0.5 seem to fix this this error for me as well.

i couldn't upgrade to 7.0.5 from 7.0.0. i got some other strange webpack error. it did work with a fresh install after removing node_modules and package-lock.json

from cli-build-app.