Giter VIP home page Giter VIP logo

Comments (5)

kitsonk avatar kitsonk commented on August 28, 2024

I guess it should use some sort of has() flag sort of thing too, so when we settle on how has build optimisation will work...

from core.

bryanforbes avatar bryanforbes commented on August 28, 2024

We'd need to update the internal _mixin function to behave more like Object.assign, but I don't see a problem doing that. Then lang.assign, lang.deepAssign, lang.mixin, and lang.deepMixin would all be able to accept primitive types without throwing. What do you think, @kfranqueiro?

from core.

bryanforbes avatar bryanforbes commented on August 28, 2024

I just spoke with @mwistrand and he told me that the internal _mixin function already behaves like Object.assign, so this might not be as hard as we first thought.

from core.

mwistrand avatar mwistrand commented on August 28, 2024

Updating lang.assign to delegate to Object.assign when available will be easy. Doing the same for lang.deepAssign might require a bit more effort.

EDIT: On second thought, since lang.deepAssign has to check the types on each source item, delegating to Object.assign doesn't even make sense.

from core.

kitsonk avatar kitsonk commented on August 28, 2024

EDIT: On second thought, since lang.deepAssign has to check the types on each source item, delegating to Object.assign doesn't even make sense.

Agreed, there doesn't seen to be an easy way to offload onto the native implementation.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.