[dev] Update Rust to the latest stable version to prevent failures in CI operations about dojo HOT 10 CLOSED

Hello @fishseabowl, thank you for the issue.

Here the decision to make is do we want to maintain the lowest rust stable version to ensure most compatibility or bumping to the latest stable for latest features.

I would tend to opt for maintaining the lowest rust stable rust version explicitely, which seems to be in this case 1.73.0.

@fishseabowl @kariy @tarrencev @kariy what's your take on this?

from dojo.

@glihm I believe we bumped rust in the past and run into some issues. i don't recall exactly what they were. but i agree we should define the rust version explicitly and not depend on a tag like stable that can change unexpectedly

from dojo.

@glihm @tarrencev At the moment, it seems that 1.73.0 would ensure highest compatibility. I agree with @glihm's suggestion; we should consider upgrading to1.73.0. Thanks

from dojo.

Let's do it. Theres a few places we will need to update: https://github.com/search?q=repo:dojoengine/dojo%201.70&type=code

from dojo.

@glihm I believe we bumped rust in the past and run into some issues. i don't recall exactly what they were.

I believe the version that we had an issue with before was 1.73.0

Something related to the CI, though i don't exactly recall what it was.

from dojo.

@fishseabowl are you willing to update your PR by bumping rust toolchain version and adjusting name of it?

If we update dependencies using cargo update the cairo dependencies may guide us to 1.74.0 from what I've seen.

from dojo.

@glihm Sure.I'll update my PR by bumping rust toolchain version to 1.74.0

from dojo.

@glihm I believe we bumped rust in the past and run into some issues. i don't recall exactly what they were.

I believe the version that we had an issue with before was 1.73.0

Something related to the CI, though i don't exactly recall what it was.

@tarrencev @kariy I found out that commit 354eebd may be related to this issue. But I didn't find the details.

from dojo.

@tarrencev @kariy I found out that commit 354eebd may be related to this issue. But I didn't find the details.

The issue was related to the release CI, but because we wanted to be quick, we didn't figure out exactly what caused it and just reverted back to 1.70.0. But I believe it was just some misconfigurations.

from dojo.

Fixed by #1412.

from dojo.