Unit tests for hash computations about dojo HOT 18 CLOSED

Will like to take care of this one!

assigned!

from dojo.

alright then

from dojo.

Will like to take care of this one!

from dojo.

@kariy @glihm (or anybody who knows) I need help with this... how can I find real transactions on Voyager that match the criteria for every test? Deploy account, Declare and Invoke transactions, for v1, v2 and v3 for each... I'm I supposed to create those transactions?

from dojo.

@kariy @glihm (or anybody who knows) I need help with this... how can I find real transactions on Voyager that match the criteria for every test? Deploy account, Declare and Invoke transactions, for v1, v2 and v3 for each... I'm I supposed to create those transactions?

You can just pick any txs (of each type) on Voyager then take their hash and the tx data that are used as inputs for the tx hash computation.

For example, to compute a invoke tx hash you'd need these data:

starknet docs for extra reference: https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/transactions/

from dojo.

hi @glihm, I would love to work on this

from dojo.

hey @Jonatan-Chaverri because there hasn't been any progress so far, i will be assigning this to @g4titanx instead.

from dojo.

@kariy Sure, sorry, have been busy these months with hackathons and other stuff. You can go ahead @g4titanx

from dojo.

okay, thanks

from dojo.

hi @kariy do you know of a faster way to search for versions of txs on voyager? i am having zero-luck finding a v3 declare type. i mean, since it's a v3 it should be among the latest txs. but even the latest txs dont use v3

from dojo.

hi @kariy do you know of a faster way to search for versions of txs on voyager? i am having zero-luck finding a v3 declare type. i mean, since it's a v3 it should be among the latest txs. but even the latest txs dont use v3

good question, tbh im also not sure. both starkscan and voyager doesn't seem to allow filtering by tx version.

i looked around the pathfinder repo for this, and maybe we can just copy the tx data for declare v3 from them https://github.com/eqlabs/pathfinder/blob/a133f157bda062187d99129367a0b18182476470/crates/common/src/transaction.rs#L1083.

from dojo.

hi @kariy do you know of a faster way to search for versions of txs on voyager? i am having zero-luck finding a v3 declare type. i mean, since it's a v3 it should be among the latest txs. but even the latest txs dont use v3

good question, tbh im also not sure. both starkscan and voyager doesn't seem to allow filtering by tx version.

i looked around the pathfinder repo for this, and maybe we can just copy the tx data for declare v3 from them https://github.com/eqlabs/pathfinder/blob/a133f157bda062187d99129367a0b18182476470/crates/common/src/transaction.rs#L1083.

yeah, we could. i entered the hash on voyager, there is no record of it tho.
does it make sense to use that same hash?

from dojo.

hi @kariy do you know of a faster way to search for versions of txs on voyager? i am having zero-luck finding a v3 declare type. i mean, since it's a v3 it should be among the latest txs. but even the latest txs dont use v3

good question, tbh im also not sure. both starkscan and voyager doesn't seem to allow filtering by tx version.
i looked around the pathfinder repo for this, and maybe we can just copy the tx data for declare v3 from them https://github.com/eqlabs/pathfinder/blob/a133f157bda062187d99129367a0b18182476470/crates/common/src/transaction.rs#L1083.

yeah, we could. i entered the hash on voyager, there is no record of it tho.

based on the test cases, it seems to be a tx from SN_GOERLI chain (which is now deprecated). lets just use that one.

from dojo.

does it make sense to use that same hash?

we just need to use chain id for SN_GOERLI when we compute the hash

from dojo.

we just need to use chain id for SN_GOERLI when we compute the hash

how do i reference the SN_GOERLI tho, it's not part of the chain id enum here

from dojo.

we just need to use chain id for SN_GOERLI when we compute the hash

how do i reference the SN_GOERLI tho, it's not part of the chain id enum here

replied on the PR, basically lets use Katana's own type for chain id, instead of starknet-rs's.

from dojo.

okay.

from dojo.

completed #2216

from dojo.