Giter VIP home page Giter VIP logo

Comments (7)

ponderingdemocritus avatar ponderingdemocritus commented on August 14, 2024 1

came here to say the same thing :)

from dojo.

ftupas avatar ftupas commented on August 14, 2024

You're the 🐐 sir, thanks

from dojo.

tarrencev avatar tarrencev commented on August 14, 2024

@kariy rather then generating a random salt, lets have the user provide a world name which we can hash to the salt. in some cases, the user will want to run migrate against an existing world, to install new components / systems for example

from dojo.

kariy avatar kariy commented on August 14, 2024

@kariy rather then generating a random salt, lets have the user provide a world name which we can hash to the salt.

perhaps it's better if we just have a --salt option for sozo migrate? name doesn't seem very intuitive

from dojo.

tarrencev avatar tarrencev commented on August 14, 2024

@kariy rather then generating a random salt, lets have the user provide a world name which we can hash to the salt.

perhaps it's better if we just have a --salt option for sozo migrate? name doesn't seem very intuitive

i like name since it abstracts the underlying implementation detail and is easily communicated. i think it is more intuitive, since without a pretty deep understanding of deployments, it's not clear what salt refers to. in the future, we can also use the name as world metadata

for example, a developer might want to modify realms world:

sozo migrate --name realms

in the future, there might be names that dont fit into 31bytes, like

sozo migrate --name world_of_warcraft_burning_crusade

in which case, we need to hash it, so we're breaking the users expectations of how the salt will be used in that case and it makes sense to have our own concept

from dojo.

kariy avatar kariy commented on August 14, 2024

i like name since it abstracts the underlying implementation detail and is easily communicated. i think it is more intuitive, since without a pretty deep understanding of deployments, it's not clear what salt refers to.

make sense

in the future, we can also use the name as world metadata

aight

from dojo.

kariy avatar kariy commented on August 14, 2024

Resolves in #654

from dojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.