Giter VIP home page Giter VIP logo

Comments (3)

dolezsa avatar dolezsa commented on July 19, 2024 1

just do it

from thermal_comfort.

dolezsa avatar dolezsa commented on July 19, 2024

sooner or later we will have to make this change, and from my point of view, especially if it is possible, as you write, with support both types, it would be best to do it so as soon as possible.
also the possibility of configuration via ui would be nice to have imho.

from thermal_comfort.

rautesamtr avatar rautesamtr commented on July 19, 2024

There's one thing I'd personally like to break but is probably not the most welcome change. Imho it would be nice if we could change the sensor name from singlewords to seperate_words. e.g. This would make them more readable easier to convert to other strings. For example one could easily generate the default friendly name of the sensor type. And if we do this we could take another look at the string for the perception sensor type. Which could be changed to thermal_perception.

class SensorType(StrEnum):
"""Sensor type enum."""
ABSOLUTEHUMIDITY = "absolutehumidity"
DEWPOINT = "dewpoint"
FROSTPOINT = "frostpoint"
FROSTRISK = "frostrisk"
HEATINDEX = "heatindex"
SIMMERINDEX = "simmerindex"
SIMMERZONE = "simmerzone"
THERMALPERCEPTION = "perception"

This could also be implemented with a mapper that accepts the old strings to keep everything backward compatible for now.

it would be best to do it so as soon as possible.
also the possibility of configuration via ui would be nice to have imho.

Sounds good. We probably should add both in the same release cycle since the both build on common stuff that needs to be added. @IATkachenko has already done a lot of the frontend stuff in #86 and with a bit of polish it should be a good foundation to build upon.

So basically having both on the next feature release would offer users the choice to either migrate to the frontend config, new yaml config or stick with their old config.

from thermal_comfort.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.