Comments (5)
peter-dolkens
commented on September 2, 2024
1
Thanks for debugging this - I'm busy cramming stuff in a suitcase for a
flight to India tomorrow, but I'll try get a release out before I fly,
otherwise I'll sort it out once I land.
Thanks
…On Fri, Nov 15, 2019 at 9:43 PM Paul Peavyhouse ***@***.***> wrote:
A quick test shows that things start working again after changing:
if ($items.length < 100)
to
if ($items.length < 10)
in HangarXPLOR.ProcessPage.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AADSVIUDJG7NTLKL6Y6WLTTQT4JWJA5CNFSM4JOADLOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGZYGA#issuecomment-554540056>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADSVIV45ARMBMJPR3P6DWDQT4JWJANCNFSM4JOADLOA>
.
from hangarxplor.
peter-dolkens
commented on September 2, 2024
1
Got a build in the store - hopefully it passes review soon.
Thanks for the report.
…On Sat, Nov 16, 2019 at 1:36 AM Peter Dolkens ***@***.***> wrote:
Thanks for debugging this - I'm busy cramming stuff in a suitcase for a
flight to India tomorrow, but I'll try get a release out before I fly,
otherwise I'll sort it out once I land.
Thanks
On Fri, Nov 15, 2019 at 9:43 PM Paul Peavyhouse ***@***.***>
wrote:
> A quick test shows that things start working again after changing:
> if ($items.length < 100)
> to
> if ($items.length < 10)
> in HangarXPLOR.ProcessPage.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#43?email_source=notifications&email_token=AADSVIUDJG7NTLKL6Y6WLTTQT4JWJA5CNFSM4JOADLOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGZYGA#issuecomment-554540056>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADSVIV45ARMBMJPR3P6DWDQT4JWJANCNFSM4JOADLOA>
> .
>
from hangarxplor.
paulpv
commented on September 2, 2024
Debugging the code while it is loading the first obvious problem is that the RSI site no longer recognizes the "pagesize" URL parameter:
https://robertsspaceindustries.com/account/pledges?page=1&pagesize=100
That only returns a page of 10 items.
I guess HangarXPLOR.ProcessPage would have be changed to loop until the list returns less than 10 items (worst case being the last page has 10 items and the next page is requested that returns 0 items).
from hangarxplor.
paulpv
commented on September 2, 2024
A quick test shows that things start working again after changing:
if ($items.length < 100)
to
if ($items.length < 10)
in HangarXPLOR.ProcessPage.
from hangarxplor.
paulpv
commented on September 2, 2024
I presume you may close this
from hangarxplor.
Related Issues (20)
- Firefox 108.0 beta on mac ventura - shows "hangar is empty" HOT 1
- Ships appear twice and some not at all. HOT 1
- Some ships unidentified HOT 4
- Firefox 108.0.2 Plugin doesent load anymore HOT 5
- Does not load fully on firefox 108.0.2 HOT 6
- Ships gifted by CIG do not show HOT 2
- Wrong Thumbnail for Badlands Nova Tank HOT 1
- Feature Request: Resize, Shrink or Hid the CCU/Ship/Package counter
- Hangar Bulk Xplorer
- Feature request: persist selected items.
- Armorsets from Foundation Event are missing in "Equipment"
- shiplist.json message to report unidentified shipnames HOT 1
- Sabre Raven appearing as normal Sabre HOT 4
- Ground Vehicle Packs improperly exporting to JSON. HOT 3
- 2953 IAE C8R Pisces not showing HOT 2
- Unidentified ship - Cutter Scout
- Headings Bug HOT 2
- Ship name does not match actual pledge. F7C-M Heartseeker HOT 4
- Referral bonuses not shown HOT 2
- Feature Request: user's currency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hangarxplor.