Is it possible to provide the styles as a .css file in addition to Sass format?

The devDependency rollup-plugin-node-resolve was updated from 4.0.0 to 4.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup-plugin-node-resolve is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 2.4.0 of eslint-plugin-import just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-import is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

• reframe/src/
• reframe/plugin/ <-- This is what is compiled into dist, 1:1

The devDependency conventional-changelog-cli was updated from 2.0.11 to 2.0.12.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

conventional-changelog-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

As it stands now, since there's no .npmignore in this project, you'll ship your landing page to all users running npm install.

What do you think about moving all landing stuff to an orphan branch and not committing it to master?

This script is great! Love the idea of using inline styles to make an iframe responsive instead of wrapping it in a div.

I was just checking out the CodePen demo in Chrome and noticed the inline styles looked like this:

max-height: calc(315px);
height: calc(56.25vw);

It seems that Chrome is automatically simplifying the calc() formulas, e.g. calc(560px * 315/560) was converted to calc(315px).

Seems like it might make sense to do this calculation in the JS and omit calc() for simplicity’s sake but wanted to run it by you before submitting a PR.

Thanks!

Can you create a Codepen or Fiddle which demos this plugin?

The devDependency rollup-plugin-commonjs was updated from 9.2.0 to 9.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup-plugin-commonjs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The issue

The reframe script breaks with the error Uncaught TypeError: Cannot read property 'indexOf' of null if no size attributes are found on the frame element.

Requested Update

Either implement a check to see if the frame has intrinsic size, and then use attributes as a fallback, or update documentation to clarify that these attributes are required.

As a workaround for now, I simply loop through the frames before and add the necessary attributes before I call reframe.

Why Is This Update Needed?

I'm using this script on a site that uses a cms (wordpress), and I can't assume every iframe/embed code will have the required size attributes.

Are There Examples Of This Requested Update Elsewhere?

This issue may be related to this pr #88

The issue can be easily replicated by simply removing the width and height attributes from the iframe in the codepen demo https://codepen.io/jakob-maudience/pen/oNNgzQd

The devDependency rollup was updated from 1.9.2 to 1.9.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Requested Update

Remove this specific line of code from jquery.reframe.js, which breaks the reframing for-loop if an element has a percentage width:

if (wAttr.indexOf('%') > -1 || frame.style.width.indexOf('%') > -1) return;

Why Is This Update Needed?

I am working on a site which has multiple content Authors, and have come across an instance whereby multiple videos within iFrames were embedded on the page. The first had a percentage width, the others did not. As a result of the above line of code, the responsive wrapping container was not applied to the subsequent iFrames.

Because the first selector has a width attribute set as a percentage, it breaks out of the for-loop which wraps the elements in a responsive wrapper, and no further elements of the current selector get processed.

Since the element is reframed in a responsive container, I don't believe this line of code is necessary. Happy to be proven wrong however :)

Thanks

TypeError: f is null refrane.min.js:8:438 on Firefox

I think I found a minor typo in the build:noframe:es gulp task:

Seems like this should be format: 'es' right?

The devDependency rollup was updated from 1.18.0 to 1.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

• embed two youtube videos
• bind youtube events onstatechange
• enable reframe on the videos

do the onstatechange events still fire reliably?
fitvids.js has this problem where youtube video onstatechange events no longer fire because the original player was removed from the DOM and then re-added (which it looks like reframe does too)

The devDependency gulp-uglify was updated from 3.0.1 to 3.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

gulp-uglify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rollup was updated from 1.27.6 to 1.27.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rollup was updated from 1.1.2 to 1.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency eslint was updated from 5.12.1 to 5.13.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.2.0 to 7.2.2.

• The devDependency @babel/preset-env was updated from 7.3.0 to 7.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Tests do not belong in the src directory. They are not the source code for your project, rather, they are auxiliary scripts meant to support the src.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Replaced the old Node.js version in your .nvmrc with the new one

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Hi

There is an issue with $ shorthand function.

window.$ is undefined in my case, instead window.jQuery works for me.

To fix this issue i did changed plugin code from,

if (window.$) {
     window.$.fn.extend({
       reframe: function reframeFunc(cName) {
         return reframe(this, cName);
      }
  });
}

To

if (window.jQuery) {
     window.jQuery.fn.extend({
       reframe: function reframeFunc(cName) {
         return reframe(this, cName);
      }
  });
}

The devDependency qunit was updated from 2.9.1 to 2.9.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

qunit is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rollup was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency conventional-changelog-cli was updated from 2.0.5 to 2.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

conventional-changelog-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴