Giter VIP home page Giter VIP logo

Comments (23)

tute avatar tute commented on May 20, 2024

I need someone to move it forward. I'm willing to help if you get stuck, but pretty much everything! Make it work, test it, garden issues, merge/reject PRs, etc.

Gave you access to do all of this in this repo, let's see what can we do! Thanks.

from doorkeeper-grants_assertion.

billyyarosh avatar billyyarosh commented on May 20, 2024

Looking for an up to date release of this gem. Can we get a bump in the version and a latest in rubygems.org?

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

That would not be a "release", as it's not tested or even human-tested to make sure it works. Until that happens, please use github: doorkeeper-gem/doorkeeper-grants_assertion in your Gemfile. If you need to merge in updates I'll be responsive to your PRs. Thanks!

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

@christopherhein @tute At the company I work we are currently quite heavily using this gem. We handle google, FB and magic link login through grants assertion. I am willing to maintain this gem :) Then the docs can be extended (and updated basing on API changes) to support FB and Google login flow and we can keep the updates to meet the changes in doorkeeper gem.

Currently in doorkeeper 3.1 breaks the compatibility of this gem (because of the way authorization request was modified). See #18 #17

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

Thanks, @matfiz! Would you like contributor access to this repo?

from doorkeeper-grants_assertion.

diegoy avatar diegoy commented on May 20, 2024

It would be great if we could release a version that is compatible with doorkeeper 3.1

Now that #18 has been fixed I'm using it in production and it looks like it's working.

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

@tute it would be great!
@diegoy i can handle that and maintain updates, if @tute agrees.

from doorkeeper-grants_assertion.

diegoy avatar diegoy commented on May 20, 2024

@matfiz If you need a pair of hands for something I'm glad to help :)

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

@matfiz added. Letting know the other developer, @NuckChorris, know.

from doorkeeper-grants_assertion.

onshi avatar onshi commented on May 20, 2024

@diegoy currently we are using version from #18 with doorkeeper 3.1.0 on our staging, so far, so good

from doorkeeper-grants_assertion.

NuckChorris avatar NuckChorris commented on May 20, 2024

Glad to have any help, obviously a release can't be made until the proper Doorkeeper hooks are in place, but right now we can probably build against that fork and maybe some infrastructural cleanup

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

@matfiz I added 2FA requirement for members of this org. That kicked you out of it, when you enable it I'll be able to invite you back.

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

@tute 2FA enabled, I should have done it long time ago!

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

@tute 2FA enabled, I should have done it long time ago!

Invitation sent! Reminder just in case: enable 2FA for your GitHub email account as well. :)

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

@tute thanks! Yeah, I keep 2FA-enabled, Github was sadly the last (as I use self-hosted Gitlab on a daily basis).

from doorkeeper-grants_assertion.

pedrocarmona avatar pedrocarmona commented on May 20, 2024

@matfiz can you release in ruby gems?

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

sure, will do :)

from doorkeeper-grants_assertion.

pedrocarmona avatar pedrocarmona commented on May 20, 2024

@tute can you release in rubygems or update maintainers in rubygems?
https://rubygems.org/gems/doorkeeper-grants_assertion/versions/0.0.1

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

@pedrocarmona I've emailed @tute, I'm waiting to be added to rubygems maintainers :)

from doorkeeper-grants_assertion.

pedrocarmona avatar pedrocarmona commented on May 20, 2024

Thanks for update @matfiz

from doorkeeper-grants_assertion.

tute avatar tute commented on May 20, 2024

@pedrocarmona I've emailed @tute, I'm waiting to be added to rubygems maintainers :)

Added! Thank you. Closing this issue for now, thanks to @matfiz.

from doorkeeper-grants_assertion.

matfiz avatar matfiz commented on May 20, 2024

Thanks, @tute!

@pedrocarmona Version 0.1.0 released to Rubygems 🎆
https://rubygems.org/gems/doorkeeper-grants_assertion/versions/0.1.0

from doorkeeper-grants_assertion.

pedrocarmona avatar pedrocarmona commented on May 20, 2024

👍

from doorkeeper-grants_assertion.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.