Implement random page API about wikipedia HOT 6 CLOSED

Are you still looking for help on this issue? If so, I'd like to pitch in.

I'm not sure what is meant by, "Implementation for this should follow the summary or related method flow". But I'm fine writing tests and using types.

from wikipedia.

Pardon the delay.

I took a look at the return formats from the API and they all looked fairly essential. So I just went ahead and creates types for all of them.

Just made a draft PR, #11. How does it look?

from wikipedia.

Sure, @friendofdog , help with this would be welcome.

You only need to use types and write unit tests, you can ignore the other part

from wikipedia.

Understood, @dopecodez . I wrote tests and a basic implementation. (Pardon me for doing so, I borrowed much from existing tests. First time using Jest.)

As for types, the Wikipedia.org API returns six unique types: 5 kinds of JSON objects or an HTML string. Should I add the missing types to resultTypes.js or is this a bit overkill?

from wikipedia.

I think it's best to borrow from existing tests.

That's an interesting question, I think we can skip over the types not currently present in the package. We would ideally need to implement the method like mobile-sections and the rest before we support the same in random.

I will take a detailed look at your changes once you open an MR, @friendofdog , thanks.

from wikipedia.

Looks good, @friendofdog . Lets continue this conversation there.

from wikipedia.