Giter VIP home page Giter VIP logo

Comments (4)

dotansimha avatar dotansimha commented on May 18, 2024

Fixed (some of the commits were squashed in order to fix some git issues).

Example for a result:

export interface FeedQueryArgs {
  type: FeedType;
  offset: number | null;
  limit: number | null;
}

export interface EntryQueryArgs {
  repoFullName: string;
}

Please try it now :)

from graphql-code-generator.

DxCx avatar DxCx commented on May 18, 2024

looks great thank you!

from graphql-code-generator.

dotansimha avatar dotansimha commented on May 18, 2024

@DxCx , what do you think about bundling the args into the query as namespace?

TypeScript supports namespacing (unlike other environments, like Swift), and we can leverage it to make cleaner code.

For example:

export namespace FeedQuery {
     export interface Args {
           // ... args
     }

     export type Result = Array<FeedItem>;
}

I use the same approach with the client side document with TypeScript, and the code looks good and organized.

from graphql-code-generator.

DxCx avatar DxCx commented on May 18, 2024

I agree with you, looks cleaners.

from graphql-code-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.