Possible bug in RecordReader about protobuf-net-data HOT 3 CLOSED

We've seen this same issue; after upgrading we get "IndexOutOfRangeException : Index was outside the bounds of the array."

Looking at the code in RecordReader, it sets the buffer size (number of columns) for the first table in the reader so if any later tables have more columns the exception is thrown when trying to access the buffer. This happens when calling GetValue and IsDBNull for example.

I've written a test and a (slightly simpler) fix. I'll raise a PR for these.

from protobuf-net-data.

This fixed the problem for me:
added is the OR part in condition
RecordReader#ReadRecord(ProtoReaderContext context)

            if (context.Buffers == null || (context.Buffers != null && context.Buffers.Length < context.Columns.Count))
            {
                context.Buffers = new ProtoDataBuffer[context.Columns.Count];

                ProtoDataBuffer.Initialize(context.Buffers);
            }
            else
            {
                ProtoDataBuffer.Clear(context.Buffers);
            }

from protobuf-net-data.

Same here, after updating to version 3 the deserialization of a dataset does not work any more..

from protobuf-net-data.