Giter VIP home page Giter VIP logo

Comments (2)

jkotas avatar jkotas commented on June 3, 2024

Introduced by #106, workaround committed as #115

from corert.

janvorli avatar janvorli commented on June 3, 2024

@jkotas in my change, I've modified the memset(this, 0x06, sizeof(this)); in the THread::Destroy to memset(this, 0x06, sizeof(*this));, based on clang warning and the fact that it seemed like the purpose was to overwrite the whole thread object. But I have missed the fact that the SetDetached call that is right after actually expects the thread state to be valid. Moreover, the DllThreadDetach expects the thread object being valid, since it checks its detached flag.
So I guess we really wanted to overwrite just the first few bytes of the Thread object, which is the beginning of the base struct of the THread, it means the ThreadBuffer::m_rgbAllocContextBuffer.

from corert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.