Giter VIP home page Giter VIP logo

Comments (4)

jmarolf avatar jmarolf commented on August 11, 2024

Yeah, I think this is correct. @JoeRobich well want to rev the version to 4.0 once all the new rules are in. Hopefully once we are at feature parity with roslyn we won't need to rev the main version number

from format.

sharwell avatar sharwell commented on August 11, 2024

I don't agree with this at all. Minor and even patch versions should be allowed to add new features, especially if those features can be turned off. If a project is using dotnet-format for validation during a build (where this scenario could break them), the consumer must take one of the following actions:

  1. Lock the version of dotnet-format (disable auto-upgrade)
  2. Accept the breaking changes

from format.

alefranz avatar alefranz commented on August 11, 2024
  1. Accept the breaking changes

The fact that it is a breaking change is what matter here! :) If this tool follows SemVer it would mean a new major version.
This would allow a better flexibility for consumers in locking a version range (essentially pinning the major version) while still allow who prefers to be on latest to do so.

from format.

sharwell avatar sharwell commented on August 11, 2024

@alefranz if we were talking about the public API, I'd be more inclined to agree. However, it turns out that most changes made to this package could be considered "breaking" on some definition. The one case where it's reasonably clear that a breaking change does not occur is the addition of a new rule, especially if the command line offers the ability run a set of rules by name. When a new rule is added, the new rule would not actually run or be used until the client updates their command line invocation to include the new rule.

from format.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.