Giter VIP home page Giter VIP logo

Comments (4)

vatsan-madhavan avatar vatsan-madhavan commented on August 24, 2024 1

@nguerrera, thoughts on changing these?

In Microsoft.NET.Sdk.WindowsDesktop.props, we have:

  <ItemGroup Condition="'$(DisableImplicitFrameworkReferences)' != 'true' And '$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
    <FrameworkReference Include="Microsoft.WindowsDesktop.App" IsImplicitlyDefined="true" />
  </ItemGroup>

Perhaps this could be condition on either UseWpf Or UseWindowsForms

  <ItemGroup Condition="'$(DisableImplicitFrameworkReferences)' != 'true' And '$(TargetFrameworkIdentifier)' == '.NETCoreApp' And ('$(UseWpf)'=='true' Or $(UseWindowsForms)=='true')">
    <FrameworkReference Include="Microsoft.WindowsDesktop.App" IsImplicitlyDefined="true" />
  </ItemGroup>

Similarly, in Microsoft.NET.Sdk.WindowsDesktop.targets, we have:

 <Import Project="$(MSBuildToolsPath)\Microsoft.WinFX.targets" 
         Condition ="'$(MSBuildRuntimeType)' != 'Core' and '$(UseLegacyPresentationBuildTasks)' == 'true'"/>

 <Import Project="Microsoft.WinFX.targets" 
         Condition="'$(MSBuildRuntimeType)' == 'Core' or '$(UseLegacyPresentationBuildTasks)' != 'true'" />

This could be conditioned on UseWpf:

 <Import Project="$(MSBuildToolsPath)\Microsoft.WinFX.targets" 
         Condition ="'$(MSBuildRuntimeType)' != 'Core' and '$(UseLegacyPresentationBuildTasks)' == 'true' and '$(UseWpf)'=='true'"/>

 <Import Project="Microsoft.WinFX.targets" 
         Condition="'$(MSBuildRuntimeType)' == 'Core' or '$(UseLegacyPresentationBuildTasks)' != 'true' and '$(UseWpf)'=='true'" />

cc @rladuca

from installer.

nguerrera avatar nguerrera commented on August 24, 2024

I think the conditions proposed make sense.

Aside: I think we can remove UseLegacyPresentationBuildTasks now. I put that there when switching over to new PBT to have an escape hatch if folks were blocked. It wasn't intended to be permanent. I don't think it even works anymore because it has a corresponding hack in the microsoft.net.windows.desktop.app targets that aren't imported after targeting pack work. cc @dsplaisted

from installer.

davidfowl avatar davidfowl commented on August 24, 2024

cc @DamianEdwards

from installer.

marcpopMSFT avatar marcpopMSFT commented on August 24, 2024

Old issue triage: We assume a solution was found for this or people have moved on so closing. We can reactivate if there is still a needed scenario for this.

from installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.