[Bug] AffineTransform ScaleX and ScaleY return invalid values. about microsoft.maui.graphics HOT 5 CLOSED

@vpenades You are correct that this could be misleading, and I'm happy to accept a pull request to change the behavior.

Like most things you've commented on, things are implemented the way they are because of specific use cases that I had, and I wasn't designing for anything beyond what I needed.

As an FYI, this code pre-dates Skia, so it's not based on SKMatrix. If you're curious, it was based on Java2D.

from microsoft.maui.graphics.

Okey, then I would suggest to rename the properties... looking at microsoft's matrices, we have

• System.Numerics.Matrix3x2
  • M11, M12, M21, M22, M31, M32
• System.Windows.Media.Matrix
  • M11, M12, M21, M22, OffsetX, OffsetY

I would suggest to follow Systen.Numerics.Matrix3x2, so I would rename both the internal fields and the public properties.

Then, I would add these extra properties:

• SizeF Scale { get; }
• PointF Translation {get;}

Translation follows the same naming convention as Matrix3x2.

Scale would return the values along the axes of the matrix, so it would return the right scales, regardless of the rotation,

let me know if you agree, or if you need to change something about the proposal, and I'll do the pull request.

from microsoft.maui.graphics.

@vpenades I agree with your proposal. I really appreciate your collaboration on this!

from microsoft.maui.graphics.

Okey, I'll be working on the PR... I think I will also need to add some unit tests

from microsoft.maui.graphics.

resolved with #189

from microsoft.maui.graphics.