Multiple calls to GetInput extension lead to new glfw input contexts about silk.net HOT 7 CLOSED

Although I guess we could change it, idk @Ultz/silk-working-group what do you think?

from silk.net.

This is by design, you should really only be calling GetInput once and keeping track of the input context.

from silk.net.

If you want to keep it this way, then this has to be documented better. Moreover a method labeled "GetXYZ" should have no side-effects by design. I would not expect that a new context is created. This should be renamed to CreateInput imho. With CreateInput I would expect a new context. But even then this context should be registered and it is not, or am I missing something?

from silk.net.

Yeah I 100% agree with you. The only reason we purposely made it so that it creates a new context is we wanted to avoid people going window.GetInput().blah for every single input call as that’s a code smell.

from silk.net.

I’ll put it up to an working group vote now.

from silk.net.

You can rename it to CreateInput to avoid your mentioned case.

from silk.net.

This was prematurely closed as this change was not implemented in InputWindowExtensions.

from silk.net.