Manifest name not match a site about dotnetthailand.github.io HOT 7 CLOSED

I found the source of this error. the pwa use config from this section of config/config.yml

@aaronamm You have 2 options for this change

• move the config to pwa section
• modify this file src/utils/config-pwa.js to use data from config directly

from dotnetthailand.github.io.

CC @aaronamm Please check this

Is it fixed by this commit? https://github.com/dotnetthailand/dotnetthailand.github.io/blob/32e82bd7c9949f895e3f67ca22ec2b15b3ceb7c3/config/config.yml

from dotnetthailand.github.io.

@kaiwanyawit-chawankul Thank for your suggestion.

We will workaround the manifest info of the site, if you know how to fix it, feel free to send the PR.

from dotnetthailand.github.io.

@kaiwanyawit-chawankul I see, Do u read this doc? https://github.com/dotnetthailand/dotnetthailand.github.io/blob/main/CONTRIBUTING.md#3-open-a-pull-request

You cannot push to main branch of this project directly, you should fork this project and create a new branch, Then create a PR.
Please follow this doc: https://github.com/dotnetthailand/dotnetthailand.github.io/blob/main/CONTRIBUTING.md#3-open-a-pull-request

from dotnetthailand.github.io.

@kaiwanyawit-chawankul Yes, I've merged. Look good.

from dotnetthailand.github.io.

@mildronize I tried but I can't create a branch. I used fork on my previous PR.

Line 87 and 88 is the fix for this issue

from dotnetthailand.github.io.

@mildronize @aaronamm please check my PR #111

from dotnetthailand.github.io.