Comments (4)
Sounds great, do you have a patch? If not I can make it.
from detweetcomposeviewcontroller.
No, haven't had time yet.
from detweetcomposeviewcontroller.
Similar bug fix is needed for DTweetPoster object created in [DETweetComposeViewController send] method.
DTweetPoster object should be created as ivar, so that after [DETweetComposeViewController cancel] action, tweet request will be really cancelled, and no delegate crashes will be occured.
- (IBAction)send
{
self.sendButton.enabled = NO;
NSString *tweet = self.textView.text;
for (NSURL *url in self.urls) {
NSString *urlString = [url absoluteString];
if ([tweet length] > 0) {
tweet = [tweet stringByAppendingString:@" "];
}
tweet = [tweet stringByAppendingString:urlString];
}
//Here tweetPoster is created, but will not be released when controller disappears,
//so it results in crash if delegate method is called after controller dissappears.
DETweetPoster *tweetPoster = [[[DETweetPoster alloc] init] autorelease];
tweetPoster = self;
[tweetPoster postTweet:tweet withImages:self.images fromAccount:self.twitterAccount];
}
from detweetcomposeviewcontroller.
I just sent out a pull request which fixes both crashes mentioned in here and also a memory leak.
See #43
from detweetcomposeviewcontroller.
Related Issues (20)
- YawkeyCleanTeeth.jpg case doesn't match HOT 2
- App crashes in iOS 4 due to access to Accounts Framework HOT 2
- Wrong saveOAuthContextToUserDefaults called HOT 5
- Transparent Background Fails with Container Views HOT 1
- -[CALayer renderInContext:] does not work with CAEAGLLayer's
- DETweetComposeViewController and ARC HOT 4
- Update to have retina support for iPad
- Delegate? HOT 2
- DEEmbossedLabel.m implement innerShadow class don't work with accent letter HOT 2
- Going to the Settings.app doesn't work in iOS 5.1 HOT 1
- BackgroundView is rotated wrongly when shown from iPad in Landscape mode HOT 2
- DEHTTPRequest hanging in iOS 4 when connection issues present
- Connection to Twitter Failed? HOT 1
- Question: Integrating DETweetComposeViewController in Adobe AIR iOS Native Extension HOT 3
- Modal dismissing as soon as it loads up HOT 2
- oauth_token is equal to blank HOT 1
- LogOut Issue in DETweetComposeViewController
- Not Tweeting HOT 3
- Duplicate symbol jsonbase with facebook.framework HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from detweetcomposeviewcontroller.