Giter VIP home page Giter VIP logo

Comments (8)

doublep avatar doublep commented on May 31, 2024 1

Please test if the performance is fine. You probably should do it with byte-compiled code, I guess difference can be substantial.

By default it looks at up to 10 lines now, or until it finds a suitable submode.

from logview.

doublep avatar doublep commented on May 31, 2024 1

I don't want to make it look too deep, I fear it will be too slow. But you can always customize new variable logview-guess-lines, 10 is not a hardcoded value.

from logview.

erichlf avatar erichlf commented on May 31, 2024

Unfortunately 10 lines isn't enough for my logs. We have a tid to name map at the beginning of our logs, so it could be 50 lines in.

from logview.

erichlf avatar erichlf commented on May 31, 2024

I had a log that started after 200 lines, so I set it to 250 and it recognized the style almost instantly. I think your code is more efficient than you think.

from logview.

doublep avatar doublep commented on May 31, 2024

In you case the first lines probably don't look anything like other log lines, so they are quickly skipped. But if I e.g. take a real log and make timestamps contain four digits after the point instead of three (so they are not matched, but still appear "promising"), it takes around 2-3 seconds with 10 lines here already.

from logview.

doublep avatar doublep commented on May 31, 2024

I just pushed a commit that makes Logview not consider all logview-guess-lines if several (by default 3) look "promising", but don't yield a successful match. Please test if this is still good enough for your logs.

from logview.

erichlf avatar erichlf commented on May 31, 2024

Still works great.

from logview.

doublep avatar doublep commented on May 31, 2024

Implemented in 0.14. I raised the default value for logview-guess-lines to 500, the default for logview-max-promising-lines remains at 3.

from logview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.