Input parameter handling for sg_wr_mode fails... about sg3_utils HOT 3 OPEN

I tend to use the sdparm utility instead of sg_wr_mode. The existing code probably worked as long as -c or -C was the last option. Anyway svn rev 1048 now mirrored here should fix it. Could you test it? And if you have a general test script (or just a hex file for input) could you send it to me and I can put it in the inhex directory?

from sg3_utils.

Hi Doug,

And thanks for the quick reply.
I can confirm that the parameter handling now works.

Placing the -c/-C option as a last one didn't make any difference because when the while loop for scanning the parameters is done (no more arguments found), the optarg content is returned as NULL.

Unfortunately, I can't provide any general test script for this. I have several scripts for multiple internal test cases and this was just one that started failing. I did used sdparm to do a one off test to verify that the functionality of the device was OK but since I'm mostly using these sg_utils for range of tests, I thought that it would be great to have this still fixed. I like the approach you have in here, easy to track down what is the problem, in case there is one :)

Thanks for the good job!

Affe

from sg3_utils.

Inspired by this bug fix, I added a --mfile=MF option so that the mask data could also be placed in a separate file (svn rev: 1049]. Then in the inhex directory the wr_mode_cont.hex and wr_mode_mask.hex files have been added. Now those files can be used together with the Linux scsi_debug driver to turn off and on the WCE bit. (i.e. Write Cache Enable).

from sg3_utils.