Giter VIP home page Giter VIP logo

Comments (6)

dpacassi avatar dpacassi commented on July 22, 2024

Hey @sir-harlekin!

Thanks for your question. Actually, if you open the web extension settings page (right click on the switch icon and select Open Disable JS settings, you can remove the www.amazon.com entry and add a amazon.com entry with Include sub-domains? checked.
That way you can whitelist/blacklist all subdomains belonging to one TLD.

This should solve your issue.
However, I find it interesting that Amazon works for you if you block things by tab but not if you block it via domain.
For me it works in both cases.
And reviewing my code, there's no difference in how to block JS for either case.

I would like to inspect this behavior a bit more. Could you please define which Amazon URL does not work for you if you disable JS by domain? And maybe not just the URL but also what exactly you expect to work (which functionality).
Also, a screenshot of your Disable JavaScript settings would be great :)

Thanks for your help!

from disable-javascript.

ugulz avatar ugulz commented on July 22, 2024

I have same problem with some sites not fully working if using "by domain". It only work properly if using "by tab" or disabling extension altogether. The one I was just using was ebay.com.au creating a listing the add photo dialog not showing. Another site it was one of those recaptcha pic select things not showing

from disable-javascript.

dpacassi avatar dpacassi commented on July 22, 2024

@ugulz Could you please provide me the exact steps on how to reproduce the issue?
Something like

  1. Start Firefox/Chrome
  2. Go to the site www.domain.com
  3. Click on the link "Example"
  4. This site is not working

In addition, please specify which browser you are using and a screenshot of your Disable JavaScript settings would also be great.

I know it's a lot on information I ask for but I can't reproduce the bug on my Windows nor on my Mac machine. Thanks a lot for your support!

from disable-javascript.

dpacassi avatar dpacassi commented on July 22, 2024

Also, please update to the web extension version 2.3.1. I've published it today, it may take up to one day for your browser to update it. Let me know if you're still experiencing any issues after the update and if so, how I can reproduce the issue, thanks a lot!

from disable-javascript.

ugulz avatar ugulz commented on July 22, 2024

its only a problem when using as whitelist. Some site load another document from another domain and scripts called from that doc aren't running unless manually add that domain to whitelist. I guess its same issue as iframe enhancement you mention in another post

from disable-javascript.

dpacassi avatar dpacassi commented on July 22, 2024

@ugulz Unfortunately I can't reproduce the described issue. Here's what I've tried:

  • Settings: Default state = off, Disable behavior = domain. Domain list = empty
  • Browse to https://pacassi.ch/jquery.html and open console
  • I only see errors about refusing to load JavaScript
  • Click on the web extension icon (pacassi.ch is added to the domain list)
  • I see the output of local executed JavaScript
  • I see that jQuery has been successfully loaded through a CDN (from code.jquery.com)

So, when allowing a site through the web extension, it will allow that site to load external JavaScript as well.
What's not handled is if the site has iframes integrated ( #41 ).

I'm therefor closing this issue. If you still experience a bug though, please open a new issue describing on how to exactly reproduce the error. Thanks!

from disable-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.