Comments (5)
Ah, I remember that now and thanks for spotting this! I'll add a test for this scenario and look into this soon.
from dprint.
Should be fixed now in the latest release.
from dprint.
@bradzacher I was looking at this more and realized the CLI args just overridding what's in the config isn't a good design. I opened #804 -- Does what's done there make sense? Let me know if you have any suggestions.
from dprint.
That seems logical to me.
Based on what I've seen internally - all the usecases we have for CLI args is exactly as you describe - we are instructing dprint to format a subset of the allowed files and nothing more.
I don't even think people use the exclude arg - they just run dprint fmt "some/folder/**/*"
to ensure their changes are good before submitting them.
Also worth noting that from CI we also don't even pass globs any more or call output-file-paths
- we have got it fast enough to just run dprint fmt
on CI!!
from dprint.
Great. I'm going to merge this and do a minor release tonight. I'm pretty confident that most people would expect this behaviour.
Also worth noting that from CI we also don't even pass globs any more or call output-file-paths - we have got it fast enough to just run dprint fmt on CI!!
That's great to hear and it's the way it should be! Way less complexity.
from dprint.
Related Issues (20)
- Possible to have `dprint` `biome` point to `biome.json` for configuration? HOT 3
- Can't Format Files In Hardlink Folder
- Support assigning a file to a formatter based on its shebang HOT 5
- Include / exclude behavior differs with `--stdin` HOT 1
- JSON config schema file HOT 1
- Offline process plugin installation instructions
- Config - Ability to include subset of another arbitrary JSON file
- Programatic API for TS (Node/Bun/Deno/etc.) HOT 2
- CLI fails to run on android-arm64
- dprint hangs sometimes HOT 3
- Memory leak in dprint-core HOT 1
- dprint attempts to format files in .git HOT 1
- plugin-prettier causes `dprint fmt` to crash on Apple M3 HOT 2
- Support for key spacing alignment HOT 2
- npm package's post-install should copy binary to node_modules/.bin folder?
- Delegate to repository-local dprint when available
- `associations` do not overwrite file extensions supported by the plugin.
- On some Windows machines: "Connection Failed: tls connection init failed: invalid peer certificate: UnknownIssuer" HOT 1
- dprint 0.46 fails to build via cargo without `--locked` flag HOT 1
- could not parse Dockerfile from version 0.46 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dprint.