Color contrast of selection / match / search result about visual-studio-code HOT 7 CLOSED

@zyxneo @jsehull Pushing out an update here in a sec that makes small adjustments to try and improve this.

The tricky part is that VSCode doesn't allow changing the foreground color of matches so it's difficult to find colors that work with the light colors of the code.

I dialed up the intensity of the non-active selection color, dialed down the intensity of the rangeSelection color (line of active selection), and increased the intensity of the active selection's yellow color.

Hopefully that helps. If not, let me know.

from visual-studio-code.

Agreed, I am definitely looking forward to an update on this (poor word/line highlights/recognition was one of the reasons I tried to find a different theme, but not anymore!)

The 1.15.0 has a nice border on the cursor line...maybe borders are easier across languages as well?

Keep up the good work @dsifford, I've been ecstatic looking forward to the updates on the theme I've been using for maybe 2-3 years now! Always fun to see improvements, thanks!

from visual-studio-code.

Hi!

Many thanks for the quick fix. I have forget to give some proper examples, so I do it now:

So I search for word "imgs/foo":

Notice, that selection works as expected, it is fine.

Than I select the "png":

Notice, that things get complicated, 3 things interact: selection, search result, and line highlight. The highlights are recognizable, however hard to differentiate between them. Which is now "selection match" for example?

Than, I do a search in "quick search" for "foobar":

Notice, hat 2 things interact: search result, and quick search result. The highlights are recognizable, even the common section. It can be improved, but also fine as it is.

Than I select word "png" again, just to display all at once:

I know, nobody makes that... But that is the worst case i can have, and I sometimes actually have it.
Oh no... wait... I can even select words from the result... But anyway. Forget any more complex cases...

What I like to point, that it is hard to differentiate between selection, selection match, search result and quick search result. I like to have something like selection: blue, selection match: skyblue, search result: yellow, quick search: green. I know, extreme stupid example, but still, some more contrast.
And yes on the other hand I already see on this single example, how hard it is, highlight the word, without loosing the contrast for readability. And there are a lot of different languages with a lot of colors too... So I don't have any Idea how to make it, I just wanted to point the wish, and make a request to think about it.

And most important in my opinion is to differentiate between actual selection and matches of the selection, e.g. 2 of 3 search result, or my selection, and same word matches.

Many thanks!

from visual-studio-code.

And I even have forget the automatic selection of string between quotes... So there are so many things to care... Therefor, I totally understand if there is no way to make secure changes... But still, nice to have :)

from visual-studio-code.

@zyxneo Thanks for the feedback. This is definitely a pain-point with the limited options available from VSCode.

If you'd like, you can try playing around with some combinations in your own theme by adding the following to your User Settings:

{
  "workbench.colorCustomizations": {
    "editor.findMatchBackground": "<hex-color-here>",
    "editor.findMatchHighlightBackground": "<hex-color-here>",
    "editor.findRangeHighlightBackground": "<hex-color-here>",
    "editor.rangeHighlightBackground": "<hex-color-here>"
    
  }
}

from visual-studio-code.

Thank you @dsifford !

And also "Keep up the good work!"

from visual-studio-code.

Thanks! Let me know if you come across a combination of colors that works well and I'll give it a shot 😄

from visual-studio-code.