I was validating supplier VAT ID's and noticed that for Slack Technologies LTD (IE3336

Ill take a look at in later today.P. <span class="email-hidden-t

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I add this test case on <a href="https://github.com/DragonBe/vies/blob/master/tests/Vi

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Validation of Irish VAT ID failed for valid VAT ID about vies HOT 7 CLOSED

dragonbe commented on June 19, 2024

Validation of Irish VAT ID failed for valid VAT ID

from vies.

Comments (7)

krzaczek commented on June 19, 2024 1

Ill take a look at in later today. P.

…

Wiadomość napisana przez Michelangelo van Dam ***@***.***> w dniu 16.04.2020, o godz. 11:45: @peter279k <https://github.com/peter279k> and @krzaczek <https://github.com/krzaczek> any ideas before I dig into this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMBTBOGCKSMD7UBKGWOXMDRM3HSBANCNFSM4MJNL2KA>.

from vies.

DragonBe commented on June 19, 2024 1

Sorry for the wait, but seem to hit a brick wall here.

I've done a clean checkout from "[email protected]:DragonBe/vies.git", added the VAT ID "3336483DH" to the tests for ValidatorIETest and ran PHPUnit. Now all tests seem to pass.

in2it-mbp:vies-clean (master) % cat tests/Vies/Validator/ValidatorIETest.php

<?php

declare (strict_types=1);

namespace DragonBe\Test\Vies\Validator;

class ValidatorIETest extends AbstractValidatorTest
{
    /**
     * @covers \DragonBe\Vies\Validator\ValidatorIE
     * @dataProvider vatNumberProvider
     */
    public function testValidator(string $vatNumber, bool $state)
    {
        $this->validateVatNumber('IE', $vatNumber, $state);
    }

    public function vatNumberProvider()
    {
        return [
            ['8Z49289F', true],
            ['3628739L', true],
            ['5343381W', true],
            ['6433435OA', true],
            ['8Z49389F', false],
            ['1234567', false],
            ['6433435OB', false],
            ['3336483DH', true],  // <-- questionable VAT ID
        ];
    }
}

in2it-mbp:vies-clean (master) % ./vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

...............................................................  63 / 221 ( 28%)
............................................................... 126 / 221 ( 57%)
............................................................... 189 / 221 ( 85%)
................................                                221 / 221 (100%)

Time: 3.57 seconds, Memory: 12.00 MB

OK (221 tests, 417 assertions)

Generating code coverage report in Clover XML format ... done

Generating code coverage report in HTML format ... done

Guess I've got some giberish in my codebase 🤦

from vies.

DragonBe commented on June 19, 2024

@peter279k and @krzaczek any ideas before I dig into this issue?

from vies.

peter279k commented on June 19, 2024

I add this test case on ValidatorIETest::vatNumberProvider().

These code snippets are as follows:

<?php

declare (strict_types=1);

namespace DragonBe\Test\Vies\Validator;

class ValidatorIETest extends AbstractValidatorTest
{
    /**
     * @covers \DragonBe\Vies\Validator\ValidatorIE
     * @dataProvider vatNumberProvider
     */
    public function testValidator(string $vatNumber, bool $state)
    {
        $this->validateVatNumber('IE', $vatNumber, $state);
    }

    public function vatNumberProvider()
    {
        return [
            ['8Z49289F', true],
            ['3628739L', true],
            ['5343381W', true],
            ['6433435OA', true],
            ['8Z49389F', false],
            ['1234567', false],
            ['6433435OB', false],
            ['IE3336483DH', false], // the problematic test case
        ];
    }
}

It will be passed on PHPUnit test.

from vies.

krzaczek commented on June 19, 2024

@peter279k @DragonBe what version of library are You using. ?

I did try the number on the latest master branch and it seems to work ok.

return [
            ['8Z49289F', true],
            ['3628739L', true],
            ['5343381W', true],
            ['6433435OA', true],
            ['3336483DH', true], //<- You should skip country prefix here `IE`
            ['8Z49389F', false],
            ['1234567', false],
            ['6433435OB', false]
        ];

→ ./vendor/bin/phpunit
PHPUnit 7.5.18 by Sebastian Bergmann and contributors.

...............................................................  63 / 221 ( 28%)
............................................................... 126 / 221 ( 57%)
............................................................... 189 / 221 ( 85%)
................................                                221 / 221 (100%)

Time: 1.24 seconds, Memory: 14.00 MB

OK (221 tests, 417 assertions)

from vies.

krzaczek commented on June 19, 2024

I did tests back to 2.1.0 versions and 2.0.4 and it always passes as valid.

from vies.

peter279k commented on June 19, 2024

@krzaczek, thanks for your reply and report.

It looks weird.

I remove vendor folder and composer.lock and run composer install.

Running php vendor/bin/phpunit again, and it's worked successfully now.

BTW, I run this on master branch.

from vies.

Validation of Irish VAT ID failed for valid VAT ID about vies HOT 7 CLOSED

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent