Giter VIP home page Giter VIP logo

Comments (2)

rasky avatar rasky commented on July 28, 2024

What would be the expected behavior?

If you specify a value that's lower than the timer callback processing time (including overhead) there are basically two options: we either ignore it (like we do now), or respect it and go into infinite loop where as soon as we exit an interrupt we must retrigger it.

from libdragon.

Dragorn421 avatar Dragorn421 commented on July 28, 2024

I would expect continuous/one-shot timers to run as soon/quick as possible

For continuous timers, it would mean I would expect a "freeze" from the timer interrupt not giving the cpu any chance to do anything useful
In that case it may be better to abort when a low-period continous timer is started

For one-shot timers, I do think it would make sense that the timer just runs as soon as possible, since it seems like a valid use case, for example imagine some code computes the ticks to wait until the next event and just happens to compute 100 ticks, then the timer never executing would be quite problematic


Suggested fixes (various ideas):

  • At the very least mention in the docs that low ticks period values should be avoided (timers wouldn't run)
  • abort when a small ticks value is used
  • use max(ticks, 10000) instead of the provided ticks in the new_timer function
  • have new_timer explicitly able to fail to start a timer, and fail to start a timer when the ticks value is low (but I'm not a fan because it leaves error checking to the user)
  • allow the user to choose among the above:
    timer_link_t* new_timer(int ticks, int flags, timer_callback1_t callback);
    ->
    enum timer_check_mode {
    TCM_NONE, // don't check the timer ticks value, timer may not run if ticks too small
    TCM_CLAMP, // use max(ticks, 10000), "guarantees" (?) the timer will run but slower than expected
    ...
    };
    
    timer_link_t* new_timer_check_ticks(int ticks, int flags, timer_callback1_t callback, enum timer_check_mode checkMode);
    
    #define new_timer(ticks, flags, callback) new_timer_check_ticks(ticks, flags, callback, TCM_NONE)
    Or add those to timer flags (TF_) instead idk

from libdragon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.