Comments (4)
Thanks for your report.
Should be fixed now.
I've pushed a new snapshot to our repository so that you'll get the fixed version as soon as your maven fetches it.
from jpasskit.
Thanks for the quick update! Unfortunately I'm afraid the date still doesn't work. The bugs do not appear to be on the jpasskit side, but may need to be dealt with anyways if relevantDate is to be supported. Apple claims it expects a W3C formatted date (ISO 8601): http://www.w3.org/TR/NOTE-datetime.
Actual:
"relevantDate": "2012-10-04T05:00:00.000+0000"
"Expected":
"relevantDate": "2012-10-04T05:00:00+00:00"
There are two bugs:
- Apple does not allow seconds in decimal notation. The W3C specification says it's OK, but passes won't load.
- Java uses the RFC 822 spec for it's timezone format, which is incorrect according to the W3C spec. Timezone must have a colon between the hours and seconds.
Perhaps down the road it may be best to allow the user to supply a date format somehow? Just a thought.
Thanks again!
from jpasskit.
Damn. You are right.
Allowing a custom date format isn't such a good idea as the format should be exactly what Apple defined it. Too much room for errors.
The PKSigningUtil is meant to be a shortcut for the people who just want to get going. They have always the possibility to just use the basic classes and do it on their own. Or just use some of its functionality while doing other parts differently. That's why I kept the other classes as clean and basic as possible.
Should be fairly easy to fix, though. Just a custom date formatter for jackson.
from jpasskit.
Nice! Worked for me. A simple timezone test also worked. Cheers.
from jpasskit.
Related Issues (20)
- missing parent pom on Maven Central Repository HOT 2
- Version missing when trying to resolve HOT 2
- Tutorial is outdated HOT 2
- Error in url
- cannot open created .pkpass with valid certs HOT 3
- DepShield Deprecation Notice
- AppleWWDRCA.cer is expired, what certificate now? HOT 4
- Jackson needs to be updated to 2.15
- Missing release of jpasskit-parent on Maven Central HOT 3
- Using .p8 certificate HOT 4
- Dropping Java 8 support HOT 3
- Switch to gradle HOT 1
- FileNotFoundException in rest.ssl.keystore.path HOT 1
- I have a pkpass that doesn't open HOT 5
- `de.brendamour.jpasskit.signing.PKSigningUtil` is deprecated HOT 5
- Foreground color does not work if background image is set HOT 5
- How to add a QR code? HOT 1
- Create multiple passes at once HOT 2
- PKPassTemplateFolder - unable to load template path from .jar file HOT 1
- About PKPass and pass.json HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jpasskit.