Support for Hebrew alphabet? about tiktok-scraper HOT 3 CLOSED

Works now from the latest version

@charlesLoder i still appreciate your efforts with the pull requests, from now all the tests are done after you submit the pull! Thank You

from tiktok-scraper.

Will take a look at it later

As always PR is welcome

from tiktok-scraper.

Hey, so I decided to take a look at this, but I didn't want to submit a PR without a little discussion first because I'm more of a hobbyist programmer and still relatively new to open source.

Adding a simple encodeURIComponent() seems to work:

// ./lib/index.js

/**
  * Get hashtag ID
  */
    async getHashTagId() {
        try {
            return await this.getIds({
                uri: `${this.mainHost}node/share/tag/${encodeURIComponent(this.input)}`,
                type: 'hashtag',
            });
        } catch (error) {
            throw new Error(error);
        }
    }

And also at lines 240 and 643.

Just testing it out worked fine:

// test.js

const TikTokScraper = require('./index.js');

const ibriyt = 'עברית';

(async () => {
    try {
        const posts = await TikTokScraper.hashtag(ibriyt, {number: 1});
        console.log(posts);
    } catch (error) {
        console.log(error);
    }
})();

Without a test suite, I wasn't sure if this would introduce more bugs though.

from tiktok-scraper.