Feature Request: have onRate fire on mouse up instead of mouse down about react-rating HOT 2 CLOSED

Great!

I released and published a new version v0.6.1 with your changes.

from react-rating.

I took a quick look at the code and right now I don't remember why I decided to use the onMouseDown as the event triggering the onChange(rate). Even the onClick(rate) event too!.

What you say makes sense to me. However, instead of relying on the onMouseUp, why not jus use the onClick event instead? This is the event that is expected to be fired when you press and release on a single element.

I propose something like this:

grep -rl 'MouseDown' src/ | xargs sed -i 's/MouseDown/Click/g'

That is, replace every onMouseDown occurrence by onClick.

Does it make sense to you? Could you try your popover scenario with these changes and see if it works?

from react-rating.