Comments (3)
This was causing a problem in my app because the client.id
corresponds to the authorized application, not the user who is authorizing. My understanding of the OmniAuth hash schema is that the uid
should be the user's unique ID in the authorizing application (e.g. Drip's user id). Is this also your understanding?
I made this change in my local gem, and it works as expected. I'd like to submit a PR, however I'm not sure how to write a test for this. Do you have any thoughts on that?
from omniauth-drip.
A PR would be welcome! This gem was originally authored by an external party, which is probably how this slipped through. You could look to the way the GitHub omniauth gem stubs out raw_info
for guidance on how to test this: https://github.com/intridea/omniauth-github/blob/master/spec/omniauth/strategies/github_spec.rb. (Admittedly, test coverage as it stands right now is very limited).
from omniauth-drip.
Good deal... I've got that PR ready for you
from omniauth-drip.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omniauth-drip.