Switch to using a logging package instead of Printf's about dgit HOT 6 CLOSED

The built-in log package is probably sufficient for this project's needs.

from dgit.

The main reason I haven't used the built-in log package is because of the timestamp that it adds by default, making it harder to get the exact same output as real git which just prints error message to stderr when things go wrong. (I assume there's a way to customize the timestamp, but I haven't looked into it.)

from dgit.

Perhaps we could use the golang logging for debugging and tracing level information and Printf for expected messages and errors? This would allow us to turn the debugging and tracing on/off at runtime and still match standard git. What do you think?

To be concrete, there can be one or more loggers that are configured using the GIT_TRACE environment variable. If the variable is not present then the loggers are no-op. If the variable is set to 1 or 2 then they dump file-name, line number and message information (ie. log.Lshortfile), which avoid dumping timestamps. Note that standard git will actually dump a timestamp for its timestamps, which would be equivalent roughly to log.Ldate | log.Ltime | log.Lshortfile.

GIT_TRACE also supports providing file paths to dump the trace. Loggers can be easily configured to write the messages to the specified file.

from dgit.

That sounds like a pretty solid plan someone wants to do it, but it sounds like a lot of work to get it set up that I don't have the time to do personally. The only thing I'd suggest changing is checking a DGIT_TRACE variable which supercedes GIT_TRACE, so that git and dgit tracing levels can be set independently.

from dgit.

I have implemented this in Pull Request #37

from dgit.

Merged

from dgit.