Giter VIP home page Giter VIP logo

Comments (10)

driusan avatar driusan commented on June 17, 2024

Does this only happen with things that use vendoring or does it happen with every repo?

It's kind of annoying, I was hoping to put off implementing submodules for a bit..

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

Ah, that's a good question. It may just be because of the repo I tried testing with. Maybe it's fine with other ones.

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

@driusan there doesn't seem to be any vendor directory or submodules in the protobuf project. I believe that go get just runs this command to update any submodules mentioned in the index if there are any.

What happens today when you clone a repo that has submodules? Will it abort? If so, we can probably get away with stubbing a no-op for this case to make go get work for any repo without submodules, which I believe would be most and rely on the initial clone failing. If not, then to do this properly we will need to implement some level of submodule support.

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

@driusan do you know any GitHub repositories that have submodules that I could try?

from dgit.

driusan avatar driusan commented on June 17, 2024

https://github.com/git/git is the first one that comes to mind.. if you want something smaller, it should be relatively easy to make a simple test repo with the normal git client

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

#109 satisfies "go get" in that if a module doesn't have any submodules then "submodule init" passes, otherwise fails. Also, "go get" runs the "show-refs" subcommand. The PR implements a stub that just outputs nothing since the tag support is incomplete. With these changes "go get" seems to be completely succeeding at least in the majority cases.

from dgit.

driusan avatar driusan commented on June 17, 2024
  1. What does go get run show-refs for?
  2. What's the connection between show-refs and tags? I thought it's mostly used to show heads.

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

@driusan I checked the go get code and it uses it to find any refs that match a tag like v2. Show-refs can show all refs including tags.

from dgit.

driusan avatar driusan commented on June 17, 2024

Ahh. That makes sense, it must be for vgo.

from dgit.

sirnewton01 avatar sirnewton01 commented on June 17, 2024

The go get tests are now passing. Unless we can think of other scenarios to test I think we can consider dgit a viable go get alternative to the official git command-line.

from dgit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.