Comments (10)
Does this only happen with things that use vendoring or does it happen with every repo?
It's kind of annoying, I was hoping to put off implementing submodules for a bit..
from dgit.
Ah, that's a good question. It may just be because of the repo I tried testing with. Maybe it's fine with other ones.
from dgit.
@driusan there doesn't seem to be any vendor directory or submodules in the protobuf project. I believe that go get just runs this command to update any submodules mentioned in the index if there are any.
What happens today when you clone a repo that has submodules? Will it abort? If so, we can probably get away with stubbing a no-op for this case to make go get work for any repo without submodules, which I believe would be most and rely on the initial clone failing. If not, then to do this properly we will need to implement some level of submodule support.
from dgit.
@driusan do you know any GitHub repositories that have submodules that I could try?
from dgit.
https://github.com/git/git is the first one that comes to mind.. if you want something smaller, it should be relatively easy to make a simple test repo with the normal git client
from dgit.
#109 satisfies "go get" in that if a module doesn't have any submodules then "submodule init" passes, otherwise fails. Also, "go get" runs the "show-refs" subcommand. The PR implements a stub that just outputs nothing since the tag support is incomplete. With these changes "go get" seems to be completely succeeding at least in the majority cases.
from dgit.
- What does
go get
runshow-refs
for? - What's the connection between
show-refs
and tags? I thought it's mostly used to show heads.
from dgit.
@driusan I checked the go get code and it uses it to find any refs that match a tag like v2. Show-refs can show all refs including tags.
from dgit.
Ahh. That makes sense, it must be for vgo.
from dgit.
The go get tests are now passing. Unless we can think of other scenarios to test I think we can consider dgit a viable go get alternative to the official git command-line.
from dgit.
Related Issues (20)
- Add support for local configuration parameters specified using "-c" global option
- Add log support for -n and -format options HOT 4
- Enhance fetch subcommand with -f and multiple groups HOT 4
- Clone is freezing when cloning from one local repo to another HOT 3
- Freeze cloning from a local repository HOT 6
- Support for git fetch depth HOT 1
- Hierarchical tags and branches aren't working properly HOT 1
- Slice bounds out of range error while running the t5510-fetch tests
- Fetch is not fetching to a destination specified by the remote.<repoid>.fetch config HOT 6
- Panic while cloning repo HOT 7
- git library is noisy HOT 2
- Unable to push - object not found HOT 7
- go master branch not invoking dgit HOT 1
- Could not find origin/master HOT 9
- panic while adding .gitignore HOT 1
- Can not index inflated thin packs
- go get fails due to bitbucket HOT 2
- dgit clone breaks on ARM64 (seems to relate to broken assumptions about memory safety/locking?)
- Migrate from Travis to GitHub Actions HOT 1
- module is not pure Go
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dgit.