Giter VIP home page Giter VIP logo

Comments (5)

flauntingspade4 avatar flauntingspade4 commented on July 17, 2024 2

Ok, I'll have a go at writing some documentation

from rustybeer.

flauntingspade4 avatar flauntingspade4 commented on July 17, 2024 1

What's the difference between calculators::boil_off and calculators::diluting, other than that calculators::diluting is missing a method to calculate a new volume? While writing the documentation I noticed they seemed identical

from rustybeer.

mlatief avatar mlatief commented on July 17, 2024

Very valid point. I can't see a difference myself. @drodil chime in?

from rustybeer.

drodil avatar drodil commented on July 17, 2024

Actually they don't have any difference. Diluting is adding more water to the batch to reach desired gravity (water amount goes up so gravity goes down) while boil-off is to remove water (water amount goes down so gravity goes up). So when doing boil-off, this calculator should return negative number indicating how much water should be removed by boiling. See a reference calculator here https://www.brewersfriend.com/dilution-and-boiloff-gravity-calculator/

from rustybeer.

flauntingspade4 avatar flauntingspade4 commented on July 17, 2024

I'm not 100% sure I follow, but if I understand correctly, we can just get rid of calculators::boil_off::BoilOff, and instead use calculators::diluting::Diluting::calculate_new_volume (I think is the correct method), and just negate, allowing us to remove calculators::boil_off::BoilOff?

from rustybeer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.