Comments (5)
Ok, I'll have a go at writing some documentation
from rustybeer.
What's the difference between calculators::boil_off
and calculators::diluting
, other than that calculators::diluting
is missing a method to calculate a new volume? While writing the documentation I noticed they seemed identical
from rustybeer.
Very valid point. I can't see a difference myself. @drodil chime in?
from rustybeer.
Actually they don't have any difference. Diluting is adding more water to the batch to reach desired gravity (water amount goes up so gravity goes down) while boil-off is to remove water (water amount goes down so gravity goes up). So when doing boil-off, this calculator should return negative number indicating how much water should be removed by boiling. See a reference calculator here https://www.brewersfriend.com/dilution-and-boiloff-gravity-calculator/
from rustybeer.
I'm not 100% sure I follow, but if I understand correctly, we can just get rid of calculators::boil_off::BoilOff
, and instead use calculators::diluting::Diluting::calculate_new_volume
(I think is the correct method), and just negate, allowing us to remove calculators::boil_off::BoilOff
?
from rustybeer.
Related Issues (20)
- Add color calculator
- Map suggested fermentables with beer style
- Add rustfmt check to workflow
- Create workflow to publish releases to crates.io
- Add rust-clippy to workflow
- Add calorie calculalator HOT 2
- Yeast viability calculator HOT 2
- Add Original Gravity calculator
- Add Final Gravity calculator
- Tests appear to be wrong HOT 1
- Add releases HOT 1
- Improve Github Pages
- Refactor rustybeer lib to use measurements library HOT 1
- Refactor calorie counter
- Refactor beer styles, hops and yeasts
- Add hydrometer temperature adjustment calculator HOT 1
- Create gravity unit
- LME/DME conversion calculator
- Fix clippy warnings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rustybeer.