Fails compiler checks for comparing floating point about json11 HOT 7 CLOSED

Comparisons on floating point numbers can be dangerous, but it's better for json11 to implement comparison as defined by the compiler (IEEE 754, etc) than to introduce potentially-surprising behavior like an epsilon. I think the right fix here is to disable the warning when compiling json11 or, if your compiler supports it, add some comments to suppress the warning.

from json11.

I am stuck with a project that enforces no float comparisons. Tried finding a way to suppress the compile error and failed. Is likely I didn't find the right way.
If I were to suggest anything I would make it a defined option.
I am now using a hacked up json11 version just to get me going.

Thanks for your comment. Closing for now.

/Matt

from json11.

One option would be switching to std::equal_to() - is your compiler happy with that?

from json11.

from json11.

What compiler are you using? Most of them have options to suppress warnings, and I don't think it would be unreasonable for us to put those warnings in the code here, so long as they were safely wrapped in #ifdefs.

from json11.

For clang, #pragma clang diagnostic ignored "-Wfloat-equal" should do it.

from json11.

Thanks for the hint. My failed search attempts didn't find that.

I am using gcc but some users are compiling the same code with clang. There is the gcc equivalent:
https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html

Which is pretty much the same thing. There is also:
#pragma GCC diagnostic push
#pragma GCC diagnostic pop

which hopefully works for clang also.

Will wrap it up in a nice #ifdef and submit a PR.

from json11.