MSVC12 Compatibility about json11 HOT 5 OPEN

Hm, apparently VS2013 is supposed to support declval. But, it looks like I forgot to include in json11.hpp. It could be that declval is accidentally available on gcc/clang because of the other includes, but not in MSVC. Does adding that #include fix it?

json11 only uses snprintf to print numbers, so it should be "safe" to replace all instances of snprintf with sprintf... I'd want to triple-check all the buffer sizes, though.

from json11.

I forgot to mention that I already added <type_traits> to check if this is the issue.
Unfortunately not, for reference here is my build output: https://gist.github.com/PaulFreund/11154815

from json11.

Just wanted to tell you that I created a copy for me that is header only and compatible with gcc and msvc12 although I currently excluded the two templates that won't compile with msvc12. It's currently very rough and looks like patchwork but it works for now.
Currently I am looking into making the objects mutable so I can spare a few copies.

from json11.

I was able to get it to compile by adding this right above namespace json11

#ifdef _MSC_VER
    #if _MSC_VER <= 1800 // VS 2013
        #define noexcept
        #define snprintf _snprintf_s
    #endif
#endif

_snprintf_s is identical to the Unix snprintf, and since noexcept isn't supported in VS2013, we just erase them.

Intellisense still doesn't like the fail method, but it seems mostly harmless.

from json11.

@retrop we can mimic noexcept with throw()
and I don't think snprintf is equal to _snprintf_s

see:

• http://stackoverflow.com/questions/12833241/difference-between-c03-throw-specifier-c11-noexcept
• https://github.com/llvm-mirror/libcxx/blob/master/include/support/win32/support.h

note:
I know that on paper noexcept != throw() but the way it is used in json11 they are more or less equal.

#ifdef _MSC_VER
    #if _MSC_VER <= 1800 // VS 2013
        #define noexcept throw()
        #define snprintf _snprintf
    #endif
#endif

from json11.