xsdgen: issues with wildcards & embedded fields about go-xml HOT 2 CLOSED

Looking into this further, I believe I've found the issue. With the commit ed9a5b5, I used something like the following strategy to override unmarshalling for individual fields in a struct:

type T RealType
var overlay struct {
	*T
	AvailabilityStartTime *xsdDateTime `xml:"availabilityStartTime,attr,omitempty"`
}
overlay.T = (*T)(t)
overlay.AvailabilityStartTime = (*xsdDateTime)(&layout.T.AvailabilityStartTime)
return d.DecodeElement(&overlay, &start)

Notably, the local type T is used to "silence" the MarshalXML method of RealType. This lets us use all the convenient reflection in the encoding/xml package while only having to override the fields we want. Now look at this example program:

https://play.golang.org/p/0el2d1S145

In short, methods of the embedded structs are not silenced by the type T trick. As a result, in the example above, if RealType had an embedded field that had its own UnmarshalXML implementation, that method would be called instead of falling through to encoding/xml's built-in unmarshalling logic.

So, the workaround here would be to forgo struct embedding, and expand the base type that a complexType extends. The internal/dependency package could be useful here for "dereferencing" types in the correct order.

This will make the generated files larger for complex schema, and make the type hierarchy less obvious. However, I don't see a better alternative.

from go-xml.

Fixed with b12a23a

from go-xml.