xsdgen: duplicated fields for nested complexType about go-xml HOT 6 CLOSED

The bug is here:

Ironically I had the comment "It's OK to modify ref", but I neglected to say "It's not OK to modify real" :)

from go-xml.

Sorry, the above case is still failed. Could you please take a double check?

from go-xml.

OK, I pushed the dup-deref branch with your patch applied, plus some extra logging to show the XML pre-processing output.

I can see what's happening now; we give the anonymous complexType a name, but when its container is dereferenced, the type comes along with it.

I think a sensible approach would be to move any nested type declarations up to the top-level if/when they get a name. Need to be a little careful when "un-nesting" anonymous types that themselves contain anonymous types.

That said, the current behavior shouldn't do any harm; the duplicated anonymous type is simply ignored. PR #43 fixed the harmful error where the source element was renamed.

from go-xml.

Ah, I can see the other problem; the type name is copied, so now you have two types named AddressType. Sorry it took me so long to realize :)

from go-xml.

Ok, this should be fixed. Give it a try and let me know if you have any trouble.

from go-xml.

Confirmed, and thanks!

from go-xml.