Inner-level complexTypes get shadowed if they share the same name about go-xml HOT 2 CLOSED

I think I see the issue. In the xsd package, the xsd.copyEltNamesToAnonTypes function correctly only copies the element name to the complexType for the first type (in depth-first order). However, the xsdgen.UseFieldNames Option then sees that the second type is anonymous, and copies the name without checking to see if it is used elsewhere. Removing that option from DefaultOptions should do the trick.

I'm still thinking about the best fix. I wonder if the UseFieldNames option is even necessary anymore, since the xsd package is already copying element names to the anonymous types they contain (avoiding collisions).

from go-xml.

Thanks! Removing UseFieldNames fixed things for my use-case. And yes, I can see that other anonymous complexTypes do have proper names assigned. Only the repeat names get assigned an Anon* type.

If there's one extra optimization you could do, it is to check if these Anon* types generated and the named types they share the element name with generate the same source code within the struct (i.e, the contents of the struct {} definition are identical). I checked that a few times, anonymous types were repeated in an XSD with identical structure which could have been refactored out as a type but wasn't done and left that way for legacy reasons. This bit was really trivial to do manually though because it's a lot easier to grok Go source than XSD.

from go-xml.