Switch to stylelint about drupal-decoupled-app HOT 8 CLOSED

Let's try 😄
stylelint (and eslint also?) doesn't have any rules enabled by default. Of course using the standard config would already add opinions, but since they are a) pretty universal and b) rules can be easily disabled it could be considered that adding stylelint promotes healthier code without forcing code style.

from drupal-decoupled-app.

Hey Maria! There is no CSS Lint in here. Are you refering to an older version of this maybe?

from drupal-decoupled-app.

Aha! I assumed so because of .csslintrc. In any case, are there any plans to use stylelint? 🙂

from drupal-decoupled-app.

That's due to the version of the Drupal backend we got running in here :). Not my file! I don't have any plans of stylelint in the repo so far. I added prettier which can also be configured for CSS files. I didn't want to add eslint/stylelint, etc. because I didn't want to impose any code style outside of what prettier defaults to. Maybe I would reconsider that. Do you have any compelling arguments for adding it to the starterkit by default?

from drupal-decoupled-app.

Okay. Let's try it then. We would have to make sure that there are no conflicts with prettier of course. Would you be up for submitting a pull request for that?

from drupal-decoupled-app.

Hey! I took a first stab with #412 :)

from drupal-decoupled-app.

Cool. Thanks! Wondering if we should also add eslint in that case :)

from drupal-decoupled-app.

Yay! Maybe? :)
Thank you!

from drupal-decoupled-app.