Comments (8)
Let's try 😄
stylelint (and eslint also?) doesn't have any rules enabled by default. Of course using the standard config would already add opinions, but since they are a) pretty universal and b) rules can be easily disabled it could be considered that adding stylelint promotes healthier code without forcing code style.
from drupal-decoupled-app.
Hey Maria! There is no CSS Lint in here. Are you refering to an older version of this maybe?
from drupal-decoupled-app.
Aha! I assumed so because of .csslintrc. In any case, are there any plans to use stylelint? 🙂
from drupal-decoupled-app.
That's due to the version of the Drupal backend we got running in here :). Not my file! I don't have any plans of stylelint in the repo so far. I added prettier which can also be configured for CSS files. I didn't want to add eslint/stylelint, etc. because I didn't want to impose any code style outside of what prettier defaults to. Maybe I would reconsider that. Do you have any compelling arguments for adding it to the starterkit by default?
from drupal-decoupled-app.
Okay. Let's try it then. We would have to make sure that there are no conflicts with prettier of course. Would you be up for submitting a pull request for that?
from drupal-decoupled-app.
Hey! I took a first stab with #412 :)
from drupal-decoupled-app.
Cool. Thanks! Wondering if we should also add eslint in that case :)
from drupal-decoupled-app.
Yay! Maybe? :)
Thank you!
from drupal-decoupled-app.
Related Issues (20)
- Automate start/stop process HOT 1
- Drupal 8.4.2+ composer update issues HOT 1
- front end installation fails
- Missing package.json file in drupal installation HOT 1
- @amazee/react-scripts – npm HOT 5
- Finalize out-of-the-box setup with features for common use-cases
- Add demo deployment with Lagoon
- Make it look pretty
- Share multi-stage docker build between backend and frontend
- Allow Lando for local development
- static files (svg, woff, ...) HOT 8
- Licence HOT 1
- ERROR: Service "cli" mounts volumes from "amazeeio-ssh-agent", which is not the name of a service or container. HOT 1
- Docker build error HOT 5
- Server side rendering Question HOT 2
- TypeError: Cannot read property 'asPath' of undefined HOT 1
- 403 when hitting graphql from frontend HOT 1
- Server Side Rendering
- "docker-compose build" failing: repository does not exist or may require authorization HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drupal-decoupled-app.