Operation types are being mapped incorrectly (v7) about openapi-typescript HOT 3 CLOSED

I can figure out a workaround unless you'd prefer I open an issue in Redocly.

No workarounds are fine. Honestly a lot of the delay of 7.x stable being released is filing down some sharp edges with Redocly. I’m glad to be using it—it offloads a ton of complexity I think it’s far better at than this library ever was—but it comes with drawbacks like this.

They're effectively no longer "testing" that a given string is a ref e.g. #/components/ anymore because they removed the / from the split.

Ah great catch! On the one hand, yeah this would be easy for them to test in some way. On the other, testing is hard 😅. Either way, I think having the fix live in this repo (and having a test for it) is smart.

from openapi-typescript.

Ah great catch. I don’t remember having tests for # characters specifically in an operationId, but it’d be great to ensure this works.

Not sure whether this was introduced with Redocly’s schema bundling, or just a net-new bug in 7.x. But either way seems like the # character is probably being parsed incorrectly (e.g. $ref: "#/components/schemas/foo").

Would love a PR for this if you (or anyone else) is able!

from openapi-typescript.

Digging in right now. Looks maybe related to this change: Redocly/redocly-cli@4ab6e09#diff-25c0338c90db3454ba7548187ad0db4e1e288ffca3c1d6ef65f45a442e728074

I can figure out a workaround unless you'd prefer I open an issue in Redocly.

edit:
Yeah if i move the parseRef function they were using for 2 years into your ts.ts and use that one instead, the test I wrote passes. They're effectively no longer "testing" that a given string is a ref e.g. #/components/ anymore because they removed the / from the split.

export function parseRef(ref: string): {
  uri: string | null;
  pointer: string[];
} {
  const [uri, pointer] = ref.split("#/");
  return {
    uri: uri || null,
    pointer: pointer
      ? pointer.split("/").map(unescapePointer).filter(isTruthy)
      : [],
  };
}

from openapi-typescript.