Giter VIP home page Giter VIP logo

Comments (4)

drwpow avatar drwpow commented on May 14, 2024

Great library!

šŸ¤—

I'm happy to provide a PR if you want

While a PR would be greatly appreciated, it would be pretty sizable in scale because this is part of the version 3 spec which isnā€™t currently supported (though itā€™s probably high time this library added that support). I think this library probably needs a rewrite to be a bit more maintainable (I wrote it before becoming more comfortable with lexers, which Iā€™d like to use moving forward, but, hey, everyoneā€™s gotta start somewhere! Even Babelā€™s first version was sebmckā€™s first crack at it).

What Iā€™ll do is open an issue to support Swagger v3 specs, and close this one, if thatā€™s all right. Hopefully this will be taken care of by that.

from openapi-typescript.

drwpow avatar drwpow commented on May 14, 2024

@Saegrov I apologizeā€”this isnā€™t unique to v3 at all! This was actually a bug. This library did support additionalProperties at the top-level, but it accidentally didnā€™t respect it for nested properties. That will be fixed in #130, and Iā€™ll push a version to npm as soon as thatā€™s good.

Also updated the tests with your exact example to ensure this stays working.

from openapi-typescript.

Saegrov avatar Saegrov commented on May 14, 2024

@DangoDev Sweet! Thank you very much!

from openapi-typescript.

SRachamim avatar SRachamim commented on May 14, 2024

Hey! Unfortunately, it seems like additionalProperties is still not supported. It generates an undefined object instead.

from openapi-typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.